Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • emulab-devel emulab-devel
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 164
    • Issues 164
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • emulabemulab
  • emulab-develemulab-devel
  • Merge requests
  • !56

Email extraction edge case fixed

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Wim Van de Meerssche requested to merge wvdemeer/emulab-devel:patch-1 into master Jan 14, 2020
  • Overview 0
  • Commits 1
  • Changes 1

2 edge cases combined resulted in the wrong email being extracted:

  • Email address with + in the name part it. (typical case: name.lastname+prefix@gmail.com)
  • Certificates with a DN that has fields positioned after the emailAddress (GN and SN in our case)

So this at the end of the DN failed: emailAdress=firstname.lastname+prefix@gmail.com/GN=firstname/SN=lastname It resulted in this extracted email address: firstname.lastname+prefix@gmail.com/GN=firstname/SN=lastname

This fixes both issues.

Note that it adds one assumption: there can never be any comma, slash or space in an email address.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: patch-1