Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • emulab-devel emulab-devel
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 165
    • Issues 165
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 6
    • Merge requests 6
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • emulabemulab
  • emulab-develemulab-devel
  • Merge requests
  • !13

fixed edge case for AMv3 POA geni_update_users

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Wim Van de Meerssche requested to merge wvdemeer/emulab-devel:amv3-poa-updateusers-edgecase into master Jun 29, 2016
  • Overview 0
  • Commits 1
  • Changes 1

There was a weird edge case for AMv2 PerformOperationalAction geni_update_users. Somehow, an undef was used as $key, which was passed along from call to call all the way from GeniAM::PerformOperationalAction to GeniCM::AddKeys's $keychecker sub. In that sub, the code $key ne "" caused a crash. This should now be fixed, by adding if (defined($key)) to GeniAM.pm.in

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: amv3-poa-updateusers-edgecase