1. 25 Jan, 2014 1 commit
  2. 02 Sep, 2013 1 commit
  3. 26 Apr, 2013 1 commit
  4. 13 Apr, 2013 3 commits
  5. 23 Mar, 2013 1 commit
  6. 18 Mar, 2013 1 commit
  7. 23 Feb, 2013 2 commits
    • Peter Maydell's avatar
      Replace all setjmp()/longjmp() with sigsetjmp()/siglongjmp() · 6ab7e546
      Peter Maydell authored
      The setjmp() function doesn't specify whether signal masks are saved and
      restored; on Linux they are not, but on BSD (including MacOSX) they are.
      We want to have consistent behaviour across platforms, so we should
      always use "don't save/restore signal mask" (this is also generally
      going to be faster). This also works around a bug in MacOSX where the
      signal-restoration on longjmp() affects the signal mask for a completely
      different thread, not just the mask for the thread which did the longjmp.
      The most visible effect of this was that ctrl-C was ignored on MacOSX
      because the CPU thread did a longjmp which resulted in its signal mask
      being applied to every thread, so that all threads had SIGINT and SIGTERM
      blocked.
      
      The POSIX-sanctioned portable way to do a jump without affecting signal
      masks is to siglongjmp() to a sigjmp_buf which was created by calling
      sigsetjmp() with a zero savemask parameter, so change all uses of
      setjmp()/longjmp() accordingly. [Technically POSIX allows sigsetjmp(buf, 0)
      to save the signal mask; however the following siglongjmp() must not
      restore the signal mask, so the pair can be effectively considered as
      "sigjmp/longjmp which don't touch the mask".]
      
      For Windows we provide a trivial sigsetjmp/siglongjmp in terms of
      setjmp/longjmp -- this is OK because no user will ever pass a non-zero
      savemask.
      
      The setjmp() uses in tests/tcg/test-i386.c and tests/tcg/linux-test.c
      are left untouched because these are self-contained singlethreaded
      test programs intended to be run under QEMU's Linux emulation, so they
      have neither the portability nor the multithreading issues to deal with.
      Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
      Reviewed-by: default avatarRichard Henderson <rth@twiddle.net>
      Tested-by: default avatarStefan Weil <sw@weilnetz.de>
      Reviewed-by: default avatarLaszlo Ersek <lersek@redhat.com>
      Signed-off-by: default avatarBlue Swirl <blauwirbel@gmail.com>
      6ab7e546
    • Peter Maydell's avatar
      disas/i386.c: Add explicit braces round empty for-loop body · af18078d
      Peter Maydell authored
      Add explicit braces round an empty for-loop body; this fits
      QEMU style and is easier to read than an inconspicuous semicolon
      at the end of the line. It also silences a clang warning:
      
      disas/i386.c:4723:49: warning: for loop has empty body [-Wempty-body]
                for (i = 0; tmp[i] == '0' && tmp[i + 1]; i++);
                                                             ^
      disas/i386.c:4723:49: note: put the semicolon on a separate line to silence this warning [-Wempty-body]
      Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
      Signed-off-by: default avatarBlue Swirl <blauwirbel@gmail.com>
      af18078d
  8. 26 Jan, 2013 1 commit
  9. 05 Jan, 2013 2 commits
  10. 02 Jan, 2013 1 commit
  11. 19 Dec, 2012 1 commit