1. 23 Nov, 2014 2 commits
  2. 18 Nov, 2014 1 commit
    • Peter Maydell's avatar
      exec: Handle multipage ranges in invalidate_and_set_dirty() · f874bf90
      Peter Maydell authored
      The code in invalidate_and_set_dirty() needs to handle addr/length
      combinations which cross guest physical page boundaries. This can happen,
      for example, when disk I/O reads large blocks into guest RAM which previously
      held code that we have cached translations for. Unfortunately we were only
      checking the clean/dirty status of the first page in the range, and then
      were calling a tb_invalidate function which only handles ranges that don't
      cross page boundaries. Fix the function to deal with multipage ranges.
      
      The symptoms of this bug were that guest code would misbehave (eg segfault),
      in particular after a guest reboot but potentially any time the guest
      reused a page of its physical RAM for new code.
      
      Cc: qemu-stable@nongnu.org
      Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
      Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      Message-id: 1416167061-13203-1-git-send-email-peter.maydell@linaro.org
      f874bf90
  3. 12 Nov, 2014 2 commits
  4. 11 Nov, 2014 2 commits
  5. 10 Nov, 2014 1 commit
  6. 04 Nov, 2014 5 commits
    • Alexander Graf's avatar
      sysbus: Add new platform bus helper device · 7634fe3c
      Alexander Graf authored
      We need to support spawning of sysbus devices dynamically via the command line.
      The easiest way to represent these dynamically spawned devices in the guest's
      memory and IRQ layout is by preallocating some space for dynamic sysbus devices.
      
      This is what the "platform bus" device does. It is a sysbus device that exports
      a configurably sized MMIO region and a configurable number of IRQ lines. When
      this device encounters sysbus devices that have been dynamically created and not
      manually wired up, it dynamically connects them to its own pool of resources.
      
      The machine model can then loop through all of these devices and create a guest
      configuration (device tree) to make them visible to the guest.
      Signed-off-by: default avatarAlexander Graf <agraf@suse.de>
      7634fe3c
    • Alexander Graf's avatar
      sysbus: Expose MMIO enumeration helper · 471a9bc1
      Alexander Graf authored
      Sysbus devices have a range of MMIO regions they expose. The exact number
      of regions is device specific and internal information to the device model.
      
      Expose whether a region exists via a public interface. That way our platform
      bus enumeration code can dynamically determine how many regions exist.
      Signed-off-by: default avatarAlexander Graf <agraf@suse.de>
      471a9bc1
    • Alexander Graf's avatar
      sysbus: Expose IRQ enumeration helpers · b7973186
      Alexander Graf authored
      Sysbus devices can get their IRQ lines connected to other devices. It is
      possible to figure out which IRQ line a connection is on and whether a sysbus
      device even provides an IRQ connector at a specific offset.
      
      This patch exposes helpers to make this information publicly accessible. We
      will need it for the platform bus dynamic sysbus enumeration.
      Signed-off-by: default avatarAlexander Graf <agraf@suse.de>
      b7973186
    • Alexander Graf's avatar
      sysbus: Make devices spawnable via -device · 33cd52b5
      Alexander Graf authored
      Now that we can properly map sysbus devices that haven't been connected to
      something forcefully by C code, we can allow the -device command line option
      to spawn them.
      
      For machines that don't implement dynamic sysbus assignment in their board
      files we add a new bool "has_dynamic_sysbus" to the machine class.
      When that property is false (default), we bail out when we see dynamically
      spawned sysbus devices, like we did before.
      Signed-off-by: default avatarAlexander Graf <agraf@suse.de>
      33cd52b5
    • Alexander Graf's avatar
      sysbus: Add dynamic sysbus device search · eb572280
      Alexander Graf authored
      Sysbus devices can be spawned by C code or dynamically via the command line.
      In the latter case, we need to be able to find the dynamically created devices
      to do things with them.
      
      This patch adds a search helper that makes it easy to look for dynamically
      spawned sysbus devices.
      Signed-off-by: default avatarAlexander Graf <agraf@suse.de>
      eb572280
  7. 03 Nov, 2014 10 commits
  8. 02 Nov, 2014 15 commits
    • Max Filippov's avatar
      hw/core/loader: implement address translation in uimage loader · 25bda50a
      Max Filippov authored
      Such address translation is needed when load address recorded in uImage
      is a virtual address. When the actual load address is requested, return
      untranslated address: user that needs the translated address can always
      apply translation function to it and those that need it untranslated
      don't need to do the inverse translation.
      
      Add translation function pointer and its parameter to uimage_load
      prototype. Update all existing users.
      
      No user-visible functional changes.
      
      Cc: qemu-stable@nongnu.org
      Signed-off-by: default avatarMax Filippov <jcmvbkbc@gmail.com>
      Reviewed-by: default avatarAlexander Graf <agraf@suse.de>
      25bda50a
    • Eduardo Habkost's avatar
      smbios: Encode UUID according to SMBIOS specification · caad057b
      Eduardo Habkost authored
      Differently from older versions, SMBIOS version 2.6 is explicit about
      the encoding of UUID fields:
      
      > Although RFC 4122 recommends network byte order for all fields, the PC
      > industry (including the ACPI, UEFI, and Microsoft specifications) has
      > consistently used little-endian byte encoding for the first three fields:
      > time_low, time_mid, time_hi_and_version. The same encoding, also known as
      > wire format, should also be used for the SMBIOS representation of the UUID.
      >
      > The UUID {00112233-4455-6677-8899-AABBCCDDEEFF} would thus be represented
      > as 33 22 11 00 55 44 77 66 88 99 AA BB CC DD EE FF.
      
      The dmidecode tool implements this and decodes the above "wire format"
      when SMBIOS version >= 2.6. We moved from SMBIOS version 2.4 to 2.8 when
      we started building the SMBIOS entry point inside QEMU, on commit
      c97294ec.
      
      Change smbios_build_type_1_table() to encode the UUID as specified.
      
      To make sure we won't change the guest-visible UUID when upgrading to a
      newer QEMU version, keep the old behavior on pc-*-2.1 and older.
      Signed-off-by: default avatarEduardo Habkost <ehabkost@redhat.com>
      Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      caad057b
    • Dr. David Alan Gilbert's avatar
      -machine vmport=off: Allow disabling of VMWare ioport emulation · 9b23cfb7
      Dr. David Alan Gilbert authored
      This is a pc & q35 only machine opt.
      
      VMWare apparently doesn't like running under QEMU due to our
      incomplete emulation of it's special IO Port.  This adds a
      pc & q35 property to allow it to be turned off.
      Signed-off-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
      Signed-off-by: default avatarDon Slutz <dslutz@verizon.com>
      Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      Reviewed-by: default avatarEduardo Habkost <ehabkost@redhat.com>
      Reviewed-by: default avatarRichard W.M. Jones <rjones@redhat.com>
      9b23cfb7
    • Gu Zheng's avatar
      cpu-hotplug: rename function for better readability · 411b5db8
      Gu Zheng authored
      Rename:
      AcpiCpuHotplug_init --> acpi_cpu_hotplug_init
      AcpiCpuHotplug_ops --> acpi_cpu_hotplug_ops
      for better readability, just cleanup.
      Reviewed-by: default avatarIgor Mammedov <imammedo@redhat.com>
      Signed-off-by: default avatarGu Zheng <guz.fnst@cn.fujitsu.com>
      Acked-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      Reviewed-by: default avatarIgor Mammedov <imammedo@redhat.com>
      411b5db8
    • Gu Zheng's avatar
      qom/cpu: remove the unused CPU hot-plug notifier · fcd702e1
      Gu Zheng authored
      Remove the unused CPU hot-plug notifier.
      Reviewed-by: default avatarIgor Mammedov <imammedo@redhat.com>
      Signed-off-by: default avatarGu Zheng <guz.fnst@cn.fujitsu.com>
      Acked-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      Reviewed-by: default avatarIgor Mammedov <imammedo@redhat.com>
      fcd702e1
    • Gu Zheng's avatar
      pc: Update rtc_cmos in pc_cpu_plug · 2d996150
      Gu Zheng authored
      Update rtc_cmos in pc_cpu_plug() directly, instead of the notifier.
      Reviewed-by: default avatarIgor Mammedov <imammedo@redhat.com>
      Signed-off-by: default avatarGu Zheng <guz.fnst@cn.fujitsu.com>
      Acked-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      Reviewed-by: default avatarIgor Mammedov <imammedo@redhat.com>
      2d996150
    • Gu Zheng's avatar
      acpi:piix4: convert cpu hotplug to hotplug_handler API · 08bba95b
      Gu Zheng authored
      Convert notifier based hotplug to hotplug_handler API,
      and remove the unused AcpiCpuHotplug_add().
      Reviewed-by: default avatarIgor Mammedov <imammedo@redhat.com>
      Signed-off-by: default avatarGu Zheng <guz.fnst@cn.fujitsu.com>
      Acked-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      Reviewed-by: default avatarIgor Mammedov <imammedo@redhat.com>
      08bba95b
    • Gu Zheng's avatar
      acpi:ich9: convert cpu hotplug to hotplug_handler API · c5171ed0
      Gu Zheng authored
      Convert notifier based hotplug to hotplug_handler API.
      Reviewed-by: default avatarIgor Mammedov <imammedo@redhat.com>
      Signed-off-by: default avatarGu Zheng <guz.fnst@cn.fujitsu.com>
      Acked-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      Reviewed-by: default avatarIgor Mammedov <imammedo@redhat.com>
      c5171ed0
    • Gu Zheng's avatar
      acpi/cpu: add cpu hotplug callback function to match hotplug_handler API · 1be6b511
      Gu Zheng authored
      Add cpu hotplug callback function (acpi_cpu_plug_cb) to match hotplug_handler API.
      Reviewed-by: default avatarIgor Mammedov <imammedo@redhat.com>
      Signed-off-by: default avatarGu Zheng <guz.fnst@cn.fujitsu.com>
      Acked-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      Reviewed-by: default avatarIgor Mammedov <imammedo@redhat.com>
      1be6b511
    • Michael S. Tsirkin's avatar
      intel_iommu: fix VTD_SID_TO_BUS · 1e06f131
      Michael S. Tsirkin authored
      (((sid) >> 8) && 0xff)  makes no sense
      (((sid) >> 8) & 0xff) seems to be what was meant.
      
      https://bugs.launchpad.net/qemu/+bug/1382477Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      
      1e06f131
    • Michael S. Tsirkin's avatar
      virtio-pci: fix migration for pci bus master · 68a27b20
      Michael S. Tsirkin authored
      Current support for bus master (clearing OK bit) together with the need to
      support guests which do not enable PCI bus mastering, leads to extra state in
      VIRTIO_PCI_FLAG_BUS_MASTER_BUG bit, which isn't robust in case of cross-version
      migration for the case when guests use the device before setting DRIVER_OK.
      
      Rip out this code, and replace it:
      -   Modern QEMU doesn't need VIRTIO_PCI_FLAG_BUS_MASTER_BUG
          so just drop it for latest machine type.
      -   For compat machine types, set PCI_COMMAND if DRIVER_OK
          is set.
      
      As this is needed for 2.1 for both pc and ppc, move PC_COMPAT macros from pc.h
      to a new common header.
      
      Cc: Greg Kurz <gkurz@linux.vnet.ibm.com>
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      Reviewed-by: default avatarAlexander Graf <agraf@suse.de>
      
      68a27b20
    • Laszlo Ersek's avatar
      well-defined listing order for machine types · 2709f263
      Laszlo Ersek authored
      Commit 261747f1 ("vl: Use MachineClass instead of global QEMUMachine
      list") broke the ordering of the machine types in the user-visible output
      of
      
        qemu-system-XXXX -M \?
      
      This occurred because registration was rebased from a manually maintained
      linked list to GLib hash tables:
      
        qemu_register_machine()
          type_register()
            type_register_internal()
              type_table_add()
                g_hash_table_insert()
      
      and because the listing was rebased accordingly, from the traversal of the
      list to the traversal of the hash table (rendered as an ad-hoc list):
      
        machine_parse()
          object_class_get_list(TYPE_MACHINE)
            object_class_foreach()
              g_hash_table_foreach()
      
      The current order is a "random" one, for practical purposes, which is
      annoying for users.
      
      Introduce new members QEMUMachine.family and MachineClass.family, allowing
      machine types to be "clustered". Introduce a comparator function that
      establishes a total ordering between machine types, ordering machine types
      in the same family next to each other. In machine_parse(), list the
      supported machine types sorted with the comparator function.
      
      The comparator function:
      - sorts whole families before standalone machine types,
      - sorts whole families between each other in alphabetically increasing
        order,
      - sorts machine types inside the same family in alphabetically decreasing
        order,
      - sorts standalone machine types between each other in alphabetically
        increasing order.
      
      After this patch, all machine types are considered standalone, and
      accordingly, the output is alphabetically ascending. This will be refined
      in the following patches.
      
      Effects on the x86_64 output:
      
      Before:
      
      > Supported machines are:
      > pc-0.13              Standard PC (i440FX + PIIX, 1996)
      > pc-i440fx-2.0        Standard PC (i440FX + PIIX, 1996)
      > pc-1.0               Standard PC (i440FX + PIIX, 1996)
      > pc-i440fx-2.1        Standard PC (i440FX + PIIX, 1996)
      > pc-q35-1.7           Standard PC (Q35 + ICH9, 2009)
      > pc-1.1               Standard PC (i440FX + PIIX, 1996)
      > pc-0.14              Standard PC (i440FX + PIIX, 1996)
      > pc-q35-2.0           Standard PC (Q35 + ICH9, 2009)
      > pc-i440fx-1.4        Standard PC (i440FX + PIIX, 1996)
      > pc-i440fx-1.5        Standard PC (i440FX + PIIX, 1996)
      > pc-0.15              Standard PC (i440FX + PIIX, 1996)
      > pc-q35-1.4           Standard PC (Q35 + ICH9, 2009)
      > isapc                ISA-only PC
      > pc                   Standard PC (i440FX + PIIX, 1996) (alias of pc-i440fx-2.2)
      > pc-i440fx-2.2        Standard PC (i440FX + PIIX, 1996) (default)
      > pc-1.2               Standard PC (i440FX + PIIX, 1996)
      > pc-0.10              Standard PC (i440FX + PIIX, 1996)
      > pc-0.11              Standard PC (i440FX + PIIX, 1996)
      > pc-q35-2.1           Standard PC (Q35 + ICH9, 2009)
      > q35                  Standard PC (Q35 + ICH9, 2009) (alias of pc-q35-2.2)
      > pc-q35-2.2           Standard PC (Q35 + ICH9, 2009)
      > pc-i440fx-1.6        Standard PC (i440FX + PIIX, 1996)
      > pc-i440fx-1.7        Standard PC (i440FX + PIIX, 1996)
      > none                 empty machine
      > pc-q35-1.5           Standard PC (Q35 + ICH9, 2009)
      > pc-q35-1.6           Standard PC (Q35 + ICH9, 2009)
      > pc-0.12              Standard PC (i440FX + PIIX, 1996)
      > pc-1.3               Standard PC (i440FX + PIIX, 1996)
      
      After:
      
      > Supported machines are:
      > isapc                ISA-only PC
      > none                 empty machine
      > pc-0.10              Standard PC (i440FX + PIIX, 1996)
      > pc-0.11              Standard PC (i440FX + PIIX, 1996)
      > pc-0.12              Standard PC (i440FX + PIIX, 1996)
      > pc-0.13              Standard PC (i440FX + PIIX, 1996)
      > pc-0.14              Standard PC (i440FX + PIIX, 1996)
      > pc-0.15              Standard PC (i440FX + PIIX, 1996)
      > pc-1.0               Standard PC (i440FX + PIIX, 1996)
      > pc-1.1               Standard PC (i440FX + PIIX, 1996)
      > pc-1.2               Standard PC (i440FX + PIIX, 1996)
      > pc-1.3               Standard PC (i440FX + PIIX, 1996)
      > pc-i440fx-1.4        Standard PC (i440FX + PIIX, 1996)
      > pc-i440fx-1.5        Standard PC (i440FX + PIIX, 1996)
      > pc-i440fx-1.6        Standard PC (i440FX + PIIX, 1996)
      > pc-i440fx-1.7        Standard PC (i440FX + PIIX, 1996)
      > pc-i440fx-2.0        Standard PC (i440FX + PIIX, 1996)
      > pc-i440fx-2.1        Standard PC (i440FX + PIIX, 1996)
      > pc                   Standard PC (i440FX + PIIX, 1996) (alias of pc-i440fx-2.2)
      > pc-i440fx-2.2        Standard PC (i440FX + PIIX, 1996) (default)
      > pc-q35-1.4           Standard PC (Q35 + ICH9, 2009)
      > pc-q35-1.5           Standard PC (Q35 + ICH9, 2009)
      > pc-q35-1.6           Standard PC (Q35 + ICH9, 2009)
      > pc-q35-1.7           Standard PC (Q35 + ICH9, 2009)
      > pc-q35-2.0           Standard PC (Q35 + ICH9, 2009)
      > pc-q35-2.1           Standard PC (Q35 + ICH9, 2009)
      > q35                  Standard PC (Q35 + ICH9, 2009) (alias of pc-q35-2.2)
      > pc-q35-2.2           Standard PC (Q35 + ICH9, 2009)
      
      Effects on the aarch64 output:
      
      Before:
      
      > Supported machines are:
      > lm3s811evb           Stellaris LM3S811EVB
      > canon-a1100          Canon PowerShot A1100 IS
      > vexpress-a15         ARM Versatile Express for Cortex-A15
      > vexpress-a9          ARM Versatile Express for Cortex-A9
      > xilinx-zynq-a9       Xilinx Zynq Platform Baseboard for Cortex-A9
      > connex               Gumstix Connex (PXA255)
      > n800                 Nokia N800 tablet aka. RX-34 (OMAP2420)
      > lm3s6965evb          Stellaris LM3S6965EVB
      > versatileab          ARM Versatile/AB (ARM926EJ-S)
      > borzoi               Borzoi PDA (PXA270)
      > tosa                 Tosa PDA (PXA255)
      > cheetah              Palm Tungsten|E aka. Cheetah PDA (OMAP310)
      > midway               Calxeda Midway (ECX-2000)
      > mainstone            Mainstone II (PXA27x)
      > n810                 Nokia N810 tablet aka. RX-44 (OMAP2420)
      > terrier              Terrier PDA (PXA270)
      > highbank             Calxeda Highbank (ECX-1000)
      > cubieboard           cubietech cubieboard
      > sx1-v1               Siemens SX1 (OMAP310) V1
      > sx1                  Siemens SX1 (OMAP310) V2
      > realview-eb-mpcore   ARM RealView Emulation Baseboard (ARM11MPCore)
      > kzm                  ARM KZM Emulation Baseboard (ARM1136)
      > akita                Akita PDA (PXA270)
      > z2                   Zipit Z2 (PXA27x)
      > musicpal             Marvell 88w8618 / MusicPal (ARM926EJ-S)
      > realview-pb-a8       ARM RealView Platform Baseboard for Cortex-A8
      > versatilepb          ARM Versatile/PB (ARM926EJ-S)
      > realview-eb          ARM RealView Emulation Baseboard (ARM926EJ-S)
      > realview-pbx-a9      ARM RealView Platform Baseboard Explore for Cortex-A9
      > spitz                Spitz PDA (PXA270)
      > none                 empty machine
      > virt                 ARM Virtual Machine
      > collie               Collie PDA (SA-1110)
      > smdkc210             Samsung SMDKC210 board (Exynos4210)
      > verdex               Gumstix Verdex (PXA270)
      > nuri                 Samsung NURI board (Exynos4210)
      > integratorcp         ARM Integrator/CP (ARM926EJ-S)
      
      After:
      
      > Supported machines are:
      > akita                Akita PDA (PXA270)
      > borzoi               Borzoi PDA (PXA270)
      > canon-a1100          Canon PowerShot A1100 IS
      > cheetah              Palm Tungsten|E aka. Cheetah PDA (OMAP310)
      > collie               Collie PDA (SA-1110)
      > connex               Gumstix Connex (PXA255)
      > cubieboard           cubietech cubieboard
      > highbank             Calxeda Highbank (ECX-1000)
      > integratorcp         ARM Integrator/CP (ARM926EJ-S)
      > kzm                  ARM KZM Emulation Baseboard (ARM1136)
      > lm3s6965evb          Stellaris LM3S6965EVB
      > lm3s811evb           Stellaris LM3S811EVB
      > mainstone            Mainstone II (PXA27x)
      > midway               Calxeda Midway (ECX-2000)
      > musicpal             Marvell 88w8618 / MusicPal (ARM926EJ-S)
      > n800                 Nokia N800 tablet aka. RX-34 (OMAP2420)
      > n810                 Nokia N810 tablet aka. RX-44 (OMAP2420)
      > none                 empty machine
      > nuri                 Samsung NURI board (Exynos4210)
      > realview-eb          ARM RealView Emulation Baseboard (ARM926EJ-S)
      > realview-eb-mpcore   ARM RealView Emulation Baseboard (ARM11MPCore)
      > realview-pb-a8       ARM RealView Platform Baseboard for Cortex-A8
      > realview-pbx-a9      ARM RealView Platform Baseboard Explore for Cortex-A9
      > smdkc210             Samsung SMDKC210 board (Exynos4210)
      > spitz                Spitz PDA (PXA270)
      > sx1                  Siemens SX1 (OMAP310) V2
      > sx1-v1               Siemens SX1 (OMAP310) V1
      > terrier              Terrier PDA (PXA270)
      > tosa                 Tosa PDA (PXA255)
      > verdex               Gumstix Verdex (PXA270)
      > versatileab          ARM Versatile/AB (ARM926EJ-S)
      > versatilepb          ARM Versatile/PB (ARM926EJ-S)
      > vexpress-a15         ARM Versatile Express for Cortex-A15
      > vexpress-a9          ARM Versatile Express for Cortex-A9
      > virt                 ARM Virtual Machine
      > xilinx-zynq-a9       Xilinx Zynq Platform Baseboard for Cortex-A9
      > z2                   Zipit Z2 (PXA27x)
      
      RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1145042Signed-off-by: default avatarLaszlo Ersek <lersek@redhat.com>
      Reviewed-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
      Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      Reviewed-by: default avatarMarcel Apfelbaum <marcel.a@redhat.com>
      Acked-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
      
      2709f263
    • Michael Tokarev's avatar
      pidfile: stop making pidfile error a special case · fee78fd6
      Michael Tokarev authored
      In case of -daemonize, we write non-zero to the daemon
      pipe only if pidfile creation failed, so the parent will
      report error about pidfile problem.  There's no need to
      make special case for this, since all other errors are
      reported by the child just fine.  Let the parent report
      error and simplify logic in os_daemonize().
      
      This way, we don't need os_pidfile_error() function, since
      it only prints error now, so put the error reporting printf
      into the only place where qemu_create_pidfile() is called,
      in vl.c.
      
      While at it, fix wrong indentation in os_daemonize().
      Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
      fee78fd6
    • Eduardo Habkost's avatar
      bitmap.h: Don't include qemu-common.h · d6aaddfe
      Eduardo Habkost authored
      This will avoid unexpected circular header dependencies in the future.
      Signed-off-by: default avatarEduardo Habkost <ehabkost@redhat.com>
      Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
      d6aaddfe
    • Eduardo Habkost's avatar
      bitops.h: Don't include qemu-common.h · afeeead1
      Eduardo Habkost authored
      This removes the following circular dependency:
      
      bitops.h -> qemu-common.h -> target-i386/cpu.h -> target-i386/cpu-qom.h ->
      qom/cpu.h -> qdev-core.h -> bitmap.h -> bitops.h.
      Signed-off-by: default avatarEduardo Habkost <ehabkost@redhat.com>
      Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
      afeeead1
  9. 31 Oct, 2014 2 commits