1. 09 Oct, 2014 1 commit
  2. 05 May, 2014 1 commit
  3. 22 Aug, 2013 1 commit
  4. 11 Mar, 2013 4 commits
  5. 20 Dec, 2012 2 commits
  6. 19 Dec, 2012 4 commits
  7. 02 Nov, 2012 5 commits
  8. 23 Oct, 2012 4 commits
    • Paolo Bonzini's avatar
      migration (incoming): add error propagation to fd and exec protocols · 43eaae28
      Paolo Bonzini authored
      And remove the superfluous integer return value.
      Reviewed-by: default avatarLuiz Capitulino <lcapitulino@redhat.com>
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      43eaae28
    • Paolo Bonzini's avatar
      migration (outgoing): add error propagation for all protocols · f37afb5a
      Paolo Bonzini authored
      Error propagation is already there for socket backends.  Add it to other
      protocols, simplifying code that tests for errors that will never happen.
      With all protocols understanding Error, the code can be simplified
      further by removing the return value.
      
      Unfortunately, the quality of error messages varies depending
      on where the error is detected, because no Error is passed to the
      NonBlockingConnectHandler.  Thus, the exact error message still cannot
      be sent to the user if the OS reports it asynchronously via SO_ERROR.
      If NonBlockingConnectHandler received an Error**, we could for
      example report the error class and/or message via a new field of the
      query-migration command even if it is reported asynchronously.
      
      Before:
      
          (qemu) migrate fd:ffff
          migrate: An undefined error has occurred
          (qemu) info migrate
          (qemu)
      
      After:
      
          (qemu) migrate fd:ffff
          migrate: File descriptor named 'ffff' has not been found
          (qemu) info migrate
          capabilities: xbzrle: off
          Migration status: failed
          total time: 0 milliseconds
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      f37afb5a
    • Paolo Bonzini's avatar
      migration: centralize call to migrate_fd_error() · 342ab8d1
      Paolo Bonzini authored
      The call to migrate_fd_error() was missing for non-socket backends, so
      centralize it in qmp_migrate().
      
      Before:
      
          (qemu) migrate fd:ffff
          migrate: An undefined error has occurred
          (qemu) info migrate
          (qemu)
      
      After:
      
          (qemu) migrate fd:ffff
          migrate: An undefined error has occurred
          (qemu) info migrate
          capabilities: xbzrle: off
          Migration status: failed
          total time: 0 milliseconds
      
      (The awful error message will be fixed later in the series).
      Reviewed-by: default avatarLuiz Capitulino <lcapitulino@redhat.com>
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      342ab8d1
    • Paolo Bonzini's avatar
      migration: avoid using error_is_set and thus relying on errp != NULL · be7059cd
      Paolo Bonzini authored
      The migration code is using errp to detect "internal" errors, this means
      that it relies on errp being non-NULL.
      
      No impact so far because our only QMP clients (the QMP marshaller and HMP)
      never pass a NULL Error **.  But if we had others, this patch would make
      sure that migration can work with a NULL Error **.
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      be7059cd
  9. 25 Sep, 2012 2 commits
  10. 13 Aug, 2012 2 commits
  11. 10 May, 2012 1 commit
    • Amos Kong's avatar
      use inet_listen()/inet_connect() to support ipv6 migration · d5c5dacc
      Amos Kong authored
      Use help functions in qemu-socket.c for tcp migration,
      which already support ipv6 addresses.
      
      Currently errp will be set to UNDEFINED_ERROR when migration fails,
      qemu would output "migration failed: ...", and current user can
      see a message("An undefined error has occurred") in monitor.
      
      This patch changed tcp_start_outgoing_migration()/inet_connect()
      /inet_connect_opts(), socket error would be passed back,
      then current user can see a meaningful err message in monitor.
      
      Qemu will exit if listening fails, so output socket error
      to qemu stderr.
      
      For IPv6 brackets must be mandatory if you require a port.
      Referencing to RFC5952, the recommended format is:
        [2312::8274]:5200
      
      test status: Successed
      listen side: qemu-kvm .... -incoming tcp:[2312::8274]:5200
      client side: qemu-kvm ...
                   (qemu) migrate -d tcp:[2312::8274]:5200
      Signed-off-by: default avatarAmos Kong <akong@redhat.com>
      Reviewed-by: default avatarOrit Wasserman <owasserm@redhat.com>
      Reviewed-by: default avatarMichael Roth <mdroth@linux.vnet.ibm.com>
      Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
      d5c5dacc
  12. 13 Jan, 2012 1 commit
  13. 12 Dec, 2011 1 commit
  14. 20 Oct, 2011 8 commits
  15. 20 Aug, 2011 1 commit
  16. 15 Apr, 2011 1 commit
  17. 20 Mar, 2011 1 commit