1. 23 Oct, 2014 2 commits
  2. 14 Oct, 2014 3 commits
  3. 04 Sep, 2014 2 commits
  4. 02 Sep, 2014 1 commit
  5. 17 Aug, 2014 2 commits
  6. 01 Jul, 2014 5 commits
  7. 30 Jun, 2014 1 commit
  8. 19 Jun, 2014 1 commit
  9. 25 Apr, 2014 1 commit
  10. 11 Apr, 2014 1 commit
  11. 19 Mar, 2014 4 commits
    • Stefan Hajnoczi's avatar
      qom: Add check() argument to object_property_add_link() · 39f72ef9
      Stefan Hajnoczi authored
      There are currently three types of object_property_add_link() callers:
      
      1. The link property may be set at any time.
      2. The link property of a DeviceState instance may only be set before
         realize.
      3. The link property may never be set, it is read-only.
      
      Something similar can already be achieved with
      object_property_add_str()'s set() argument.  Follow its example and add
      a check() argument to object_property_add_link().
      
      Also provide default check() functions for case #1 and #2.  Case #3 is
      covered by passing a NULL function pointer.
      
      Cc: Peter Crosthwaite <peter.crosthwaite@petalogix.com>
      Cc: Alexander Graf <agraf@suse.de>
      Cc: Anthony Liguori <aliguori@amazon.com>
      Cc: "Michael S. Tsirkin" <mst@redhat.com>
      Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
      Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      [AF: Tweaked documentation comment]
      Signed-off-by: default avatarAndreas Färber <afaerber@suse.de>
      39f72ef9
    • Stefan Hajnoczi's avatar
      qom: Make QOM link property unref optional · 9561fda8
      Stefan Hajnoczi authored
      Some object_property_add_link() callers expect property deletion to
      unref the link property object.  Other callers expect to manage the
      refcount themselves.  The former are currently broken and therefore leak
      the link property object.
      
      This patch adds a flags argument to object_property_add_link() so the
      caller can specify which refcount behavior they require.  The new
      OBJ_PROP_LINK_UNREF_ON_RELEASE flag causes the link pointer to be
      unreferenced when the property is deleted.
      
      This fixes refcount leaks in qdev.c, xilinx_axidma.c, xilinx_axienet.c,
      s390-virtio-bus.c, virtio-pci.c, virtio-rng.c, and ui/console.c.
      
      Rationale for refcount behavior:
      
       * hw/core/qdev.c
         - bus children are explicitly unreferenced, don't interfere
         - parent_bus is essentially a read-only property that doesn't hold a
           refcount, don't unref
         - hotplug_handler is leaked, do unref
      
       * hw/dma/xilinx_axidma.c
         - rx stream "dma" links are set using set_link, therefore they
           need unref
         - tx streams are set using set_link, therefore they need unref
      
       * hw/net/xilinx_axienet.c
         - same reasoning as hw/dma/xilinx_axidma.c
      
       * hw/pcmcia/pxa2xx.c
         - pxa2xx bypasses set_link and therefore does not use refcounts
      
       * hw/s390x/s390-virtio-bus.c
       * hw/virtio/virtio-pci.c
       * hw/virtio/virtio-rng.c
       * ui/console.c
         - set_link is used and there is no explicit unref, do unref
      
      Cc: Peter Crosthwaite <peter.crosthwaite@petalogix.com>
      Cc: Alexander Graf <agraf@suse.de>
      Cc: Anthony Liguori <aliguori@amazon.com>
      Cc: "Michael S. Tsirkin" <mst@redhat.com>
      Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
      Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      Signed-off-by: default avatarAndreas Färber <afaerber@suse.de>
      9561fda8
    • Stefan Hajnoczi's avatar
      qom: Don't make link NULL on object_property_set_link() failure · c6aed983
      Stefan Hajnoczi authored
      The error behavior of object_property_set_link() is dangerous.  It sets
      the link property object to NULL if an error occurs.  A setter function
      should either succeed or fail, it shouldn't leave the value NULL on
      failure.
      Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
      Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      Signed-off-by: default avatarAndreas Färber <afaerber@suse.de>
      c6aed983
    • Stefan Hajnoczi's avatar
      qom: Split object_property_set_link() · f5ec6704
      Stefan Hajnoczi authored
      The path resolution logic in object_property_set_link() should be a
      separate function.  This makes the code easier to read and maintain.
      Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
      Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      Signed-off-by: default avatarAndreas Färber <afaerber@suse.de>
      f5ec6704
  12. 13 Mar, 2014 1 commit
  13. 12 Mar, 2014 1 commit
  14. 14 Feb, 2014 1 commit
  15. 06 Jan, 2014 1 commit
  16. 24 Dec, 2013 3 commits
  17. 19 Nov, 2013 1 commit
  18. 14 Oct, 2013 1 commit
  19. 30 Aug, 2013 2 commits
  20. 16 Aug, 2013 1 commit
  21. 10 Jul, 2013 1 commit
  22. 04 Jul, 2013 1 commit
  23. 22 May, 2013 1 commit
  24. 13 May, 2013 2 commits
    • Anthony Liguori's avatar
      qom: aggressively optimize qom casting · 03587328
      Anthony Liguori authored
      This patch adds a small typename cache to ObjectClass.  This allows
      caching positive casts within each ObjectClass.  Benchmarking a
      PPC workload provided by Aurelien, this patch eliminates every
      single g_hash_table_lookup() happening during the benchmark (which
      was about 2 million per-second).
      
      With this patch applied, I get exactly the same performance (within
      the margin of error) as with --disable-qom-cast-debug.
      
      N.B. it's safe to cache typenames only from the _assert() macros
      because they are always called with string literals.
      Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
      03587328
    • Paolo Bonzini's avatar
      qom: allow turning cast debugging off · 3556c233
      Paolo Bonzini authored
      Cast debugging can have a substantial cost (20% or more).  Instead of adding
      special-cased "fast casts" in the hot paths, we can just disable it in
      releases.  The tracing facilities we just added make it easier to analyze
      those problems that cast debugging would reveal.
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      Message-id: 1368188203-3407-7-git-send-email-pbonzini@redhat.com
      Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
      3556c233