1. 14 Nov, 2014 1 commit
  2. 28 Oct, 2014 3 commits
  3. 20 Sep, 2014 1 commit
  4. 24 Jun, 2014 1 commit
  5. 10 Jun, 2014 2 commits
  6. 09 Jun, 2014 3 commits
  7. 26 May, 2014 2 commits
    • Michael Tokarev's avatar
      libcacard: remove useless initializers · 1687a089
      Michael Tokarev authored
      libcacard has many functions which initializes local variables
      at declaration time, which are always assigned some values later
      (often right after declaration).  Clean up these initializers.
      Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
      1687a089
    • Michael Tokarev's avatar
      libcacard: fix wrong array expansion logic · d09b8fa1
      Michael Tokarev authored
      The currrent code in libcacard/vcard_emul_nss.c:vcard_emul_options()
      has a weird bug in variable usage around expanding opts->vreader
      array.
      
      There's a helper variable, vreaderOpt, which is first needlessly
      initialized to NULL, next, conditionally, only we have to expand
      opts->vreader, receives array expansion from g_renew(), and next,
      even if we don't actually perform expansion, the value of this
      variable is assigned to the actual array, opts->vreader, which
      was supposed to be expanded.
      
      So, since we expand the array by READER_STEP increments, only
      once in READER_STEP (=4) the code will work, in other 3/4 times
      it will fail badly.
      
      Fix this by not using this temp variable when expanding the
      array, and by dropping the useless =NULL initializer too -
      if it wasn't in place initially, compiler would have warned
      us about this problem at the beginning.
      Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
      Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
      d09b8fa1
  8. 23 May, 2014 7 commits
  9. 09 May, 2014 1 commit
    • Michael Tokarev's avatar
      libcacard: remove libcacard-specific CFLAGS and LIBS from global vars · 9d171bd9
      Michael Tokarev authored
      Currently all what's needed for single file libcacard/vcard_emul_nss.c
      (libnss cflags) and hw/usb/ccid-card-emulated.c (libcacard includes)
      together with the libs is added to global QEMU_CFLAGS and libs_softmmu.
      
      Use the cflags only where really used (for two mentioned files), and
      libs only where needed.
      
      While at it, rename variables to better reflect reality: libcacard_*
      is really nss_*.
      
      This needs a bit more tweaking: $(NSS_LIBS) should not contain $glib_libs
      (ditto for _cflags).  But in order to fix it, some more preparations
      should be made first.  So add a FIXME comment.
      Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      9d171bd9
  10. 07 May, 2014 2 commits
  11. 09 Mar, 2014 1 commit
  12. 09 Feb, 2014 1 commit
  13. 16 Dec, 2013 1 commit
  14. 09 Dec, 2013 1 commit
    • Stefan Weil's avatar
      libcacard: Fix compilation for older versions of glib (bug #1258168) · 5ad04fb6
      Stefan Weil authored
      See https://bugs.launchpad.net/bugs/1258168
      
      libcacard/vscclient.c: In function 'do_socket_read':
      libcacard/vscclient.c:410: warning: implicit declaration of function 'g_warn_if_reached'
      libcacard/vscclient.c:410: warning: nested extern declaration of 'g_warn_if_reached'
      libcacard/vscclient.c: In function 'main':
      libcacard/vscclient.c:763: warning: implicit declaration of function 'g_byte_array_unref'
      libcacard/vscclient.c:763: warning: nested extern declaration of 'g_byte_array_unref'
      ...
      libcacard/vscclient.o: In function `do_socket_read':
      libcacard/vscclient.c:410: undefined reference to `g_warn_if_reached'
      libcacard/vscclient.o: In function `main':
      libcacard/vscclient.c:763: undefined reference to `g_byte_array_unref'
      
      g_warn_if_reached was added in glib 2.16, and g_byte_array_unref is
      supported since glib 2.22. QEMU requires glib 2.12, so both names must
      not be used.
      
      Instead of showing a warning for code which should not be reached,
      vscclient better stop running, so g_warn_if_reached is not useful for
      vscclient.
      
      In libcacard/vsclient.c, g_byte_array_unref can be replaced by
      g_byte_array_free. This is not generally true, so adding a compatibility
      layer in include/glib-compat.h is no option here.
      Reported-by: default avatarLaurent Desnogues <laurent.desnogues@gmail.com>
      Reported-by: default avatarDon Slutz <dslutz@verizon.com>
      Signed-off-by: default avatarStefan Weil <sw@weilnetz.de>
      5ad04fb6
  15. 02 Dec, 2013 2 commits
  16. 20 Sep, 2013 1 commit
  17. 18 Sep, 2013 1 commit
  18. 01 Sep, 2013 1 commit
  19. 21 Jun, 2013 1 commit
  20. 12 Jun, 2013 1 commit
  21. 24 Apr, 2013 6 commits