• Max Reitz's avatar
    block: Add status callback to bdrv_amend_options() · 77485434
    Max Reitz authored
    Depending on the changed options and the image format,
    bdrv_amend_options() may take a significant amount of time. In these
    cases, a way to be informed about the operation's status is desirable.
    
    Since the operation is rather complex and may fundamentally change the
    image, implementing it as AIO or a coroutine does not seem feasible. On
    the other hand, implementing it as a block job would be significantly
    more difficult than a simple callback and would not add benefits other
    than progress report to the amending operation, because it should not
    actually be run as a block job at all.
    
    A callback may not be very pretty, but it's very easy to implement and
    perfectly fits its purpose here.
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Reviewed-by: default avatarBenoît Canet <benoit.canet@nodalink.com>
    Reviewed-by: default avatarKevin Wolf <kwolf@redhat.com>
    Message-id: 1414404776-4919-2-git-send-email-mreitz@redhat.com
    Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    77485434
block_int.h 23.3 KB