Skip to content
  • Anthony Liguori's avatar
    vnc: Fix password expiration through 'change vnc ""' (v2) · 1cd20f8b
    Anthony Liguori authored
    commit 52c18be9
    
     introduced a regression in the
    change vnc password command that changed the behavior of setting the VNC
    password to an empty string from disabling login to disabling authentication.
    
    This commit refactors the code to eliminate this overloaded semantics in
    vnc_display_password and instead introduces the vnc_display_disable_login.   The
    monitor implementation then determines the behavior of an empty or missing
    string.
    
    Recently, a set_password command was added that allows both the Spice and VNC
    password to be set.  This command has not shown up in a release yet so the
    behavior is not yet defined.
    
    This patch proposes that an empty password be treated as an empty password with
    no special handling.  For specifically disabling login, I believe a new command
    should be introduced instead of overloading semantics.
    
    I'm not sure how Spice handles this but I would recommend that we have Spice
    and VNC have consistent semantics here for the 0.14.0 release.
    
    Reported-by: default avatarNeil Wilson <neil@aldur.co.uk>
    Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
    ---
    v1 -> v2
     - Add a proper return to make sure that login is really disabled instead of
       relying on the VNC server to treat empty passwords specially
    1cd20f8b