Skip to content
  • Isaku Yamahata's avatar
    pci: don't overwrite multi functio bit in pci header type. · b80d4a98
    Isaku Yamahata authored
    
    
    Don't overwrite pci header type.
    Otherwise, multi function bit which pci_init_header_type() sets
    appropriately is lost.
    Anyway PCI_HEADER_TYPE_NORMAL is zero, so it is unnecessary to zero
    which is already zero cleared.
    
    how to test:
    run qemu and issue info pci to see whether a device in question is
    normal device, not pci-to-pci bridge.
    This is handy because guest os isn't required.
    
    tested changes:
    The following files are covered by using following commands.
    sparc64-softmmu
      apb_pci.c, vga-pci.c, cmd646.c, ne2k_pci.c, sun4u.c
    ppc-softmmu
      grackle_pci.c, cmd646.c, ne2k_pci.c, vga-pci.c, macio.c
    ppc-softmmu -M mac99
      unin_pci.c(uni-north, uni-north-agp)
    ppc64-softmmu
      pci-ohci, ne2k_pci, vga-pci, unin_pci.c(u3-agp)
    x86_64-softmmu
      acpi_piix4.c, ide/piix.c, piix_pci.c
      -vga vmware vmware_vga.c
      -watchdog i6300esb wdt_i6300esb.c
      -usb usb-uhci.c
      -sound ac97 ac97.c
      -nic model=rtl8139 rtl8139.c
      -nic model=pcnet pcnet.c
      -balloon virtio virtio-pci.c:
    
    untested changes:
    The following changes aren't tested.
    prep_pci.c: ppc-softmmu -M prep should cover, but core dumped.
    unin_pci.c(uni-north-pci): the caller is commented out.
    openpic.c: the caller is commented out in ppc_prep.c
    
    Signed-off-by: default avatarIsaku Yamahata <yamahata@valinux.co.jp>
    Signed-off-by: default avatarBlue Swirl <blauwirbel@gmail.com>
    b80d4a98