Skip to content
  • Christoph Hellwig's avatar
    block: add topology qdev properties · 428c149b
    Christoph Hellwig authored
    
    
    Add three new qdev properties to export block topology information to
    the guest.  This is needed to get optimal I/O alignment for RAID arrays
    or SSDs.
    
    The options are:
    
     - physical_block_size to specify the physical block size of the device,
       this is going to increase from 512 bytes to 4096 kilobytes for many
       modern storage devices
     - min_io_size to specify the minimal I/O size without performance impact,
       this is typically set to the RAID chunk size for arrays.
     - opt_io_size to specify the optimal sustained I/O size, this is
       typically the RAID stripe width for arrays.
    
    I decided to not auto-probe these values from blkid which might easily
    be possible as I don't know how to deal with these issues on migration.
    
    Note that we specificly only set the physical_block_size, and not the
    logial one which is the unit all I/O is described in.  The reason for
    that is that IDE does not support increasing the logical block size and
    at last for now I want to stick to one meachnisms in queue and allow
    for easy switching of transports for a given backing image which would
    not be possible if scsi and virtio use real 4k sectors, while ide only
    uses the physical block exponent.
    
    To make this more common for the different block drivers introduce a
    new BlockConf structure holding all common block properties and a
    DEFINE_BLOCK_PROPERTIES macro to add them all together, mirroring
    what is done for network drivers.  Also switch over all block drivers
    to use it, except for the floppy driver which has weird driveA/driveB
    properties and probably won't require any advanced block options ever.
    
    Example usage for a virtio device with 4k physical block size and
    8k optimal I/O size:
    
      -drive file=scratch.img,media=disk,cache=none,id=scratch \
      -device virtio-blk-pci,drive=scratch,physical_block_size=4096,opt_io_size=8192
    
    aliguori: updated patch to take into account BLOCK events
    
    Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
    Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
    428c149b