Skip to content
  • Stefan Hajnoczi's avatar
    blockdev: reset werror/rerror on drive_del · 293c51a6
    Stefan Hajnoczi authored
    
    
    Paolo Bonzini <pbonzini@redhat.com> suggested the following test case:
    
    1. Launch a guest and wait at the GRUB boot menu:
    
      qemu-system-x86_64 -enable-kvm -m 1024 \
       -drive if=none,cache=none,file=test.img,id=foo,werror=stop,rerror=stop
       -device virtio-blk-pci,drive=foo,id=virtio0,addr=4
    
    2. Hot unplug the device:
    
      (qemu) drive_del foo
    
    3. Select the first boot menu entry
    
    Without this patch the guest pauses due to ENOMEDIUM.  The guest is
    stuck in a continuous pause loop since the I/O request is retried and
    fails immediately again when the guest is resumed.
    
    With this patch the error is reported to the guest.
    
    Note that this scenario actually happens sometimes during libvirt disk
    hot unplug, where device_del is followed by drive_del.  I/O may still be
    submitted to the drive after drive_del if the guest does not process the
    PCI hot unplug notification.
    
    Reported-by: default avatarDafna Ron <dron@redhat.com>
    Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    Reviewed-by: default avatarKevin Wolf <kwolf@redhat.com>
    293c51a6