Skip to content
  • Stefan Weil's avatar
    vnc: Fix packed boolean struct members · ee032ca1
    Stefan Weil authored
    
    
    This patch fixes warnings reported by splint:
    
    For variables which are packed in a single bit, a signed data type
    like 'int' does not make much sense.
    
    There is no obvious reason why the two values should be packed,
    so I removed the packing and changed the data type to bool
    because both are used as boolean values.
    
    v2:
    
    Some versions of gcc complain after this modification,
    for example gcc (Debian 4.4.5-8) 4.4.5):
    
    ui/vnc-auth-sasl.c: In function ‘vnc_sasl_client_cleanup’:
    ui/vnc-auth-sasl.c:34: error: suggest parentheses around assignment used as truth value
    
    Obviously, the compiler does not like code which does
    bool = unsigned = bool = 0
    
    Splitting that code in three statements works.
    
    Cc: Anthony Liguori <aliguori@us.ibm.com>
    Signed-off-by: default avatarStefan Weil <sw@weilnetz.de>
    Signed-off-by: default avatarStefan Hajnoczi <stefanha@linux.vnet.ibm.com>
    ee032ca1