Skip to content
  • Juan Quintela's avatar
    mips_fulong2e: Don't register "cpu" VMState twice · 0c9dfe46
    Juan Quintela authored
    
    
    We have the following simplified callgraph in mips_fulong2e_init():
    
      cpu_init() => cpu_mips_init()
        object_new()
          mips_cpu_initfn()
            cpu_exec_init()
              register_savevm(NULL, "cpu", cpu_index, CPU_SAVE_VERSION,
                              cpu_save, cpu_load, env)
      register_savevm(NULL, "cpu", 0, 3, cpu_save, cpu_load, env)
    
    CPU_SAVE_VERSION is defined as 3 in target-mips/cpu.h.
    fulong2e instantiates one CPU, so its cpu_index is 0.
    Thus the two are fully identical.
    
    Therefore just remove the second call in fulong2e.
    
    Signed-off-by: default avatarJuan Quintela <quintela@redhat.com>
    [AF: Extend explanation in commit message]
    Signed-off-by: default avatarAndreas Färber <afaerber@suse.de>
    0c9dfe46