Skip to content
  • Riku Voipio's avatar
    linux-user: strace now handles guest stringscorrectly [v2] · 03dfe9f8
    Riku Voipio authored
    
    
    On Tue, Jun 16, 2009 at 08:19:23PM -0500, Anthony Liguori wrote:
    > malc wrote:
    >>
    >> On my system the above line causes gcc to emit:
    >>
    >> In file included from /home/malc/x/rcs/git/qemu/linux-user/strace.c:12:
    >> /usr/include/linux/futex.h:48: error: field `__user' has incomplete type
    >> /usr/include/linux/futex.h:48: error: syntax error before '*' token
    >> /usr/include/linux/futex.h:63: error: field `list' has incomplete type
    >> /usr/include/linux/futex.h:83: error: field `__user' has incomplete type
    >> /usr/include/linux/futex.h:83: error: syntax error before '*' token
    >> make[1]: *** [strace.o] Error 1
    
    > We had the same problem with usb-linux.c.  It's broken system headers,
    > the __user stuff is supposed to get removed as part of the headers
    > installation.
    
    > It builds fine on my system (Fedora 10).
    
    Howabout something like this:
    
    commit eb8387cb0eda32a18880664eb5f0ca5c8bf05b45
    Author: Riku Voipio <riku.voipio@iki.fi>
    Date:   Thu Jun 18 22:44:31 2009 +0300
    Subject: linux-user: include futex defines directly
    
    Since some common distributions have broken linux/futex.h, stop
    including it. Instead add the defines directly.
    
    Signed-off-by: default avatarRiku Voipio <riku.voipio@iki.fi>
    03dfe9f8