1. 20 Dec, 2012 6 commits
  2. 19 Dec, 2012 7 commits
  3. 17 Dec, 2012 1 commit
  4. 12 Dec, 2012 2 commits
    • David Gibson's avatar
      migration: Fix madvise breakage if host and guest have different page sizes · 45e6cee4
      David Gibson authored
      madvise(DONTNEED) will throw away the contents of the whole page at the
      given address, even if the given length is less than the page size.  One
      can argue about whether that's the correct behaviour, but that's what it's
      done for a long time in Linux at least.
      
      That means that the madvise() in ram_load(), on a setup where
      TARGET_PAGE_SIZE is smaller than the host page size, can throw away data
      in guest pages adjacent to the one it's actually processing right now,
      leading to guest memory corruption on an incoming migration.
      
      This patch therefore, disables the madvise() if the host page size is
      larger than TARGET_PAGE_SIZE.  This means we don't get the benefits of that
      madvise() in this case, but a more complete fix is more difficult to
      accomplish.  This at least fixes the guest memory corruption.
      Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
      Reported-by: default avatarAlexey Kardashevskiy <aik@ozlabs.ru>
      Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
      45e6cee4
    • David Gibson's avatar
      Fix off-by-1 error in RAM migration code · 7ec81e56
      David Gibson authored
      The code for migrating (or savevm-ing) memory pages starts off by creating
      a dirty bitmap and filling it with 1s.  Except, actually, because bit
      addresses are 0-based it fills every bit except bit 0 with 1s and puts an
      extra 1 beyond the end of the bitmap, potentially corrupting unrelated
      memory.  Oops.  This patch fixes it.
      Signed-off-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
      Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
      7ec81e56
  5. 17 Oct, 2012 10 commits
  6. 21 Sep, 2012 1 commit
  7. 19 Sep, 2012 1 commit
  8. 14 Sep, 2012 1 commit
  9. 22 Aug, 2012 1 commit
  10. 11 Aug, 2012 1 commit
  11. 08 Aug, 2012 5 commits
  12. 02 Aug, 2012 1 commit
    • Peter Maydell's avatar
      Support 'help' as a synonym for '?' in command line options · c8057f95
      Peter Maydell authored
      For command line options which permit '?' meaning 'please list the
      permitted values', add support for 'help' as a synonym, by abstracting
      the check out into a helper function.
      
      This change means that in some cases where we were being lazy in
      our string parsing, "?junk" will now be rejected as an invalid option
      rather than being (undocumentedly) treated the same way as "?".
      
      Update the documentation to use 'help' rather than '?', since '?'
      is a shell metacharacter and thus prone to fail confusingly if there
      is a single character filename in the current working directory and
      the '?' has not been escaped. It's therefore better to steer users
      towards 'help', though '?' is retained for backwards compatibility.
      
      We do not, however, update the output of the system emulator's -help
      (or any documentation autogenerated from the qemu-options.hx which
      is the source of the -help text) because libvirt parses our -help
      output and will break. At a later date when QEMU provides a better
      interface so libvirt can avoid having to do this, we can update the
      -help text too.
      Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
      Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
      c8057f95
  13. 27 Jul, 2012 1 commit
  14. 23 Jul, 2012 1 commit
  15. 20 Jul, 2012 1 commit