1. 20 Oct, 2010 20 commits
  2. 17 Oct, 2010 2 commits
  3. 13 Oct, 2010 12 commits
    • Blue Swirl's avatar
      trace: print a warning if user tries to enable an unknown trace event · f871d689
      Blue Swirl authored
      
      
      There was no warning if a bad trace event name was given to
      'trace-event' command, thus the user could think that the command
      was successful even if this was not the case.
      
      Print a warning if the user tries to enable a trace event which is not
      known.
      Acked-by: default avatarStefan Hajnoczi <stefanha@linux.vnet.ibm.com>
      Signed-off-by: default avatarBlue Swirl <blauwirbel@gmail.com>
      f871d689
    • Blue Swirl's avatar
      mips: avoid write only variables · 2abf314d
      Blue Swirl authored
      
      
      Compiling with GCC 4.6.0 20100925 produced a lot of warnings like:
      /src/qemu/target-mips/translate.c: In function 'gen_ld':
      /src/qemu/target-mips/translate.c:1039:17: error: variable 'opn' set but not used [-Werror=unused-but-set-variable]
      
      Fix by adding a dummy cast so that the variable is not unused.
      Signed-off-by: default avatarBlue Swirl <blauwirbel@gmail.com>
      2abf314d
    • Blue Swirl's avatar
      ppc: avoid write only variables · 577f25a5
      Blue Swirl authored
      
      
      Compiling with GCC 4.6.0 20100925 produced warnings:
      /src/qemu/target-ppc/op_helper.c: In function 'helper_icbi':
      /src/qemu/target-ppc/op_helper.c:351:14: error: variable 'tmp' set but not used [-Werror=unused-but-set-variable]
      /src/qemu/target-ppc/op_helper.c: In function 'do_6xx_tlb':
      /src/qemu/target-ppc/op_helper.c:3805:28: error: variable 'EPN' set but not used [-Werror=unused-but-set-variable]
      /src/qemu/target-ppc/op_helper.c: In function 'do_74xx_tlb':
      /src/qemu/target-ppc/op_helper.c:3838:28: error: variable 'EPN' set but not used [-Werror=unused-but-set-variable]
      
      Fix by adding a dummy cast so that the variable is not unused. Delete tmp.
      Signed-off-by: default avatarBlue Swirl <blauwirbel@gmail.com>
      577f25a5
    • Blue Swirl's avatar
      i386: avoid a write only variable · 4581cbcd
      Blue Swirl authored
      
      
      Compiling with GCC 4.6.0 20100925 produced warnings:
      /src/qemu/target-i386/op_helper.c: In function 'switch_tss':
      /src/qemu/target-i386/op_helper.c:283:53: error: variable 'new_trap' set but not used [-Werror=unused-but-set-variable]
      
      Fix by adding a dummy cast so that the variable is not unused. Add also
      pointer to docs.
      Signed-off-by: default avatarBlue Swirl <blauwirbel@gmail.com>
      4581cbcd
    • Blue Swirl's avatar
      vnc: avoid write only variables · 2ded6ad7
      Blue Swirl authored
      
      
      Compiling with GCC 4.6.0 20100925 produced warnings:
      /src/qemu/ui/vnc.c: In function 'vnc_client_cache_auth':
      /src/qemu/ui/vnc.c:217:12: error: variable 'qdict' set but not used [-Werror=unused-but-set-variable]
      /src/qemu/ui/vnc.c: In function 'vnc_display_open':
      /src/qemu/ui/vnc.c:2526:9: error: variable 'acl' set but not used [-Werror=unused-but-set-variable]
      
      Fix by making the variable declarations and their uses also conditional
      to debug definition.
      Signed-off-by: default avatarBlue Swirl <blauwirbel@gmail.com>
      2ded6ad7
    • Blue Swirl's avatar
      cris: avoid a write only variable · 03e654c0
      Blue Swirl authored
      
      
      Compiling with GCC 4.6.0 20100925 produced a warning:
      In file included from /src/qemu/target-cris/translate.c:3154:0:
      /src/qemu/target-cris/translate_v10.c: In function 'dec10_prep_move_m':
      /src/qemu/target-cris/translate_v10.c:111:22: error: variable 'rd' set but not used [-Werror=unused-but-set-variable]
      
      Fix by deleting rd, adjust the only user.
      Signed-off-by: default avatarBlue Swirl <blauwirbel@gmail.com>
      03e654c0
    • Blue Swirl's avatar
      Delete write only variables · 49a2942d
      Blue Swirl authored
      
      
      Compiling with GCC 4.6.0 20100925 produced warnings like:
      /src/qemu/net/tap-win32.c: In function 'tap_win32_open':
      /src/qemu/net/tap-win32.c:582:12: error: variable 'hThread' set but not used [-Werror=unused-but-set-variable]
      
      Fix by removing the unused variables.
      Signed-off-by: default avatarBlue Swirl <blauwirbel@gmail.com>
      49a2942d
    • Blue Swirl's avatar
      ppc: remove video.x · ae0bfb79
      Blue Swirl authored
      
      
      Only Mac-on-Linux stuff used video.x, OpenBIOS does not need it.
      
      Remove video.x MoL hacks.
      Signed-off-by: default avatarAlexander Graf <agraf@suse.de>
      Signed-off-by: default avatarBlue Swirl <blauwirbel@gmail.com>
      ae0bfb79
    • Blue Swirl's avatar
      lsi53c895a: avoid a write only variable · f3f5b867
      Blue Swirl authored
      
      
      Compiling with GCC 4.6.0 20100925 produced a warning:
      /src/qemu/hw/lsi53c895a.c: In function 'lsi_do_msgout':
      /src/qemu/hw/lsi53c895a.c:848:9: error: variable 'len' set but not used [-Werror=unused-but-set-variable]
      
      Fix by adding a dummy cast so that the variable is not unused for
      non-debug case.
      Signed-off-by: default avatarBlue Swirl <blauwirbel@gmail.com>
      f3f5b867
    • Blue Swirl's avatar
      eepro100: initialize a variable in all cases · ef476062
      Blue Swirl authored
      
      
      Compiling with GCC 4.6.0 20100925 produced warnings:
      /src/qemu/hw/eepro100.c: In function 'eepro100_read4':
      /src/qemu/hw/eepro100.c:1351:14: error: 'val' may be used uninitialized in this function [-Werror=uninitialized]
      /src/qemu/hw/eepro100.c: In function 'eepro100_read2':
      /src/qemu/hw/eepro100.c:1328:14: error: 'val' may be used uninitialized in this function [-Werror=uninitialized]
      /src/qemu/hw/eepro100.c: In function 'eepro100_read1':
      /src/qemu/hw/eepro100.c:1285:13: error: 'val' may be used uninitialized in this function [-Werror=uninitialized]
      
      Fix by initializing 'val' at start.
      Signed-off-by: default avatarBlue Swirl <blauwirbel@gmail.com>
      ef476062
    • Blue Swirl's avatar
      cirrus: avoid write only variables · 8c78881f
      Blue Swirl authored
      
      
      Compiling with GCC 4.6.0 20100925 produced a lot of warnings like:
      In file included from /src/qemu/hw/cirrus_vga_rop.h:174:0,
                       from /src/qemu/hw/cirrus_vga.c:284:
      /src/qemu/hw/cirrus_vga_rop2.h: In function 'cirrus_patternfill_0_8':
      /src/qemu/hw/cirrus_vga_rop2.h:48:18: error: variable 'col' set but not used [-Werror=unused-but-set-variable]
      /src/qemu/hw/cirrus_vga_rop2.h: In function 'cirrus_colorexpand_transp_0_8':
      /src/qemu/hw/cirrus_vga_rop2.h:104:18: error: variable 'col' set but not used [-Werror=unused-but-set-variable]
      
      Fix the warnings by introducing an inline function, which avoids
      exposing write-only variables.
      Signed-off-by: default avatarBlue Swirl <blauwirbel@gmail.com>
      8c78881f
    • Blue Swirl's avatar
      block: avoid a write only variable · 83e3f76c
      Blue Swirl authored
      
      
      Compiling with GCC 4.6.0 20100925 produced a warning:
      /src/qemu/block/qcow2-refcount.c: In function 'update_refcount':
      /src/qemu/block/qcow2-refcount.c:552:13: error: variable 'dummy' set but not used [-Werror=unused-but-set-variable]
      
      Fix by adding a dummy cast so that the result is not unused.
      Acked-by: default avatarKevin Wolf <kwolf@redhat.com>
      Signed-off-by: default avatarBlue Swirl <blauwirbel@gmail.com>
      83e3f76c
  4. 11 Oct, 2010 1 commit
  5. 09 Oct, 2010 5 commits