1. 26 Jan, 2013 5 commits
  2. 24 Jan, 2013 6 commits
    • Anthony Liguori's avatar
      Merge remote-tracking branch 'bonzini/scsi-next' into staging · 11c29918
      Anthony Liguori authored
      # By Paolo Bonzini (1) and Peter Lieven (1)
      # Via Paolo Bonzini
      * bonzini/scsi-next:
        iscsi: add support for iovectors
        iscsi: do not leak acb->buf when commands are aborted
      11c29918
    • Michael Tokarev's avatar
      Revert "serial: fix retry logic" · b37a2e45
      Michael Tokarev authored
      This reverts commit 67c5322d
      
      :
      
          I'm not sure if the retry logic has ever worked when not using FIFO mode.  I
          found this while writing a test case although code inspection confirms it is
          definitely broken.
      
          The TSR retry logic will never actually happen because it is guarded by an
          'if (s->tsr_rety > 0)' but this is the only place that can ever make the
          variable greater than zero.  That effectively makes the retry logic an 'if (0)
      
          I believe this is a typo and the intention was >= 0.  Once this is fixed thoug
          I see double transmits with my test case.  This is because in the non FIFO
          case, serial_xmit may get invoked while LSR.THRE is still high because the
          character was processed but the retransmit timer was still active.
      
          We can handle this by simply checking for LSR.THRE and returning early.  It's
          possible that the FIFO paths also need some attention.
      
          Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
      Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
      
      Even if the previous logic was never worked, new logic breaks stuff -
      namely,
      
       qemu -enable-kvm -nographic -kernel /boot/vmlinuz-$(uname -r) -append console=ttyS0 -serial pty
      
      the above command will cause the virtual machine to stuck at startup
      using 100% CPU till one connects to the pty and sends any char to it.
      
      Note this is rather typical invocation for various headless virtual
      machines by libvirt.
      
      So revert this change for now, till a better solution will be found.
      Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
      Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
      b37a2e45
    • Peter Lieven's avatar
      iscsi: add support for iovectors · 7371d56f
      Peter Lieven authored
      
      
      This patch adds support for directly passing the iovec
      array from QEMUIOVector if libiscsi supports it (1.8.0
      or newer).
      Signed-off-by: default avatarPeter Lieven <pl@kamp.de>
      [Preserve the improvements from commit 4cc841b5
      
      , iscsi: partly
       avoid iovec linearization in iscsi_aio_writev, 2012-11-19 - Paolo]
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      7371d56f
    • Paolo Bonzini's avatar
      iscsi: do not leak acb->buf when commands are aborted · 4790b03d
      Paolo Bonzini authored
      
      
      acb->buf is freed in the WRITE(16) callback, but this may not
      get called at all when commands are aborted.  Add another
      free in the ABORT TASK callback, which requires setting acb->buf
      to NULL everywhere.
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      4790b03d
    • Andreas Färber's avatar
      target-cris: Fix typo in D_LOG() macro · 3f668b6c
      Andreas Färber authored
      It's __VA_ARGS__. Fixes the build with CRIS_[OP_]HELPER_DEBUG defined.
      
      Broken since r6338 / 93fcfe39
      
       (Convert
      references to logfile/loglevel to use qemu_log*() macros).
      
      Cc: Eduardo Habkost <ehabkost@redhat.com>
      Signed-off-by: default avatarAndreas Färber <afaerber@suse.de>
      Signed-off-by: default avatarEdgar E. Iglesias <edgar.iglesias@gmail.com>
      3f668b6c
    • Grant Likely's avatar
      trivial: etraxfs_eth: Eliminate checkpatch errors · 9fc7577a
      Grant Likely authored
      
      
      This is a trivial patch to harmonize the coding style on
      hw/etraxfs_eth.c. This is in preparation to split off the bitbang mdio
      code into a separate file.
      
      Cc: Peter Maydell <peter.maydell@linaro.org>
      Cc: Paul Brook <paul@codesourcery.com>
      Cc: Edgar E. Iglesias <edgar.iglesias@gmail.com>
      Cc: Anthony Liguori <aliguori@us.ibm.com>
      Cc: Andreas Färber <afaerber@suse.de>
      Signed-off-by: default avatarGrant Likely <grant.likely@secretlab.ca>
      Signed-off-by: default avatarEdgar E. Iglesias <edgar.iglesias@gmail.com>
      9fc7577a
  3. 23 Jan, 2013 3 commits
  4. 22 Jan, 2013 11 commits
  5. 21 Jan, 2013 15 commits