1. 27 Nov, 2014 1 commit
    • Marcel Apfelbaum's avatar
      hmp: fix regression of HMP device_del auto-completion · 4cae4d5a
      Marcel Apfelbaum authored
      The commits:
       - 6a1fa9f5 (monitor: add del completion for peripheral device)
       - 66e56b13
      
       (qdev: add qdev_build_hotpluggable_device_list helper)
      
      cause a QEMU crash when trying to use HMP device_del auto-completion.
      It can be easily reproduced by:
          <qemu-bin> -enable-kvm  ~/images/fedora.qcow2 -monitor stdio -device virtio-net-pci,id=vnet
      
          (qemu) device_del
          /home/mapfelba/git/upstream/qemu/hw/core/qdev.c:941:qdev_build_hotpluggable_device_list: Object 0x7f6ce04e4fe0 is not an instance of type device
          Aborted (core dumped)
      
      The root cause is qdev_build_hotpluggable_device_list going recursively over
      all peripherals and their children assuming all are devices. It doesn't work
      since PCI devices have at least on child which is a memory region (bus master).
      
      Solved by observing that all devices appear as direct children of
      /machine/peripheral container. No need of going recursively
      over all the children.
      
      Signed-off-by: default avatarMarcel Apfelbaum <marcel.a@redhat.com>
      Reported-by: default avatarGal Hammer <ghammer@redhat.com>
      Reviewed-by: default avatarIgor Mammedov <imammedo@redhat.com>
      Message-id: 1417002601-20799-1-git-send-email-marcel.a@redhat.com
      Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
      4cae4d5a
  2. 10 Nov, 2014 1 commit
  3. 04 Nov, 2014 1 commit
  4. 24 Oct, 2014 1 commit
    • Markus Armbruster's avatar
      hmp: Remove "info pcmcia" · 7797a739
      Markus Armbruster authored
      
      
      This command lists PCMCIA sockets and cards.  Only a few ARM boards
      have sockets (akita, borzoi, connex, mainstone, spitz, terrier, tosa,
      verdex, z2), the only card is the DSCM-1xxxx Hitachi Microdrive (qdev
      "microdrive"), and it is only inserted during machine init, if ever.
      So this command doesn't really tell anybody anything new so far.
      
      Moreover, pcmcia_socket_unregister() has a use-after-free bug, flagged
      by Coverity.  Has never been used, because there has never been code
      to eject a PCMCIA card.
      
      Not worth fixing & converting to QMP.  Remove it.
      
      Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
      Acked-by: default avatarLuiz Capitulino <lcapitulino@redhat.com>
      Acked-by: default avatarAndreas Färber <afaerber@suse.de>
      Message-id: 1411144812-22958-1-git-send-email-armbru@redhat.com
      Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
      7797a739
  5. 23 Oct, 2014 2 commits
  6. 20 Oct, 2014 2 commits
  7. 26 Sep, 2014 3 commits
  8. 12 Sep, 2014 1 commit
  9. 18 Aug, 2014 2 commits
  10. 07 Aug, 2014 1 commit
  11. 30 Jun, 2014 1 commit
    • Roger Pau Monne's avatar
      serial: poll the serial console with G_IO_HUP · e02bc6de
      Roger Pau Monne authored
      On FreeBSD polling a master pty while the other end is not connected
      with G_IO_OUT only results in an endless wait. This is different from
      the Linux behaviour, that returns immediately. In order to demonstrate
      this, I have the following example code:
      
      http://xenbits.xen.org/people/royger/test_poll.c
      
      
      
      When executed on Linux:
      
      $ ./test_poll
      In callback
      
      On FreeBSD instead, the callback never gets called:
      
      $ ./test_poll
      
      So, in order to workaround this, poll the source with G_IO_HUP (which
      makes the code behave the same way on both Linux and FreeBSD).
      
      Signed-off-by: default avatarRoger Pau Monné <roger.pau@citrix.com>
      Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
      Cc: Michael Tokarev <mjt@tls.msk.ru>
      Cc: "Andreas Färber" <afaerber@suse.de>
      Cc: Paolo Bonzini <pbonzini@redhat.com>
      Cc: xen-devel@lists.xenproject.org
      [Add hw/char/cadence_uart.c too. - Paolo]
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      e02bc6de
  12. 29 Jun, 2014 1 commit
  13. 27 Jun, 2014 2 commits
  14. 23 Jun, 2014 10 commits
  15. 19 Jun, 2014 3 commits
  16. 16 Jun, 2014 1 commit
  17. 11 Jun, 2014 6 commits
  18. 05 Jun, 2014 1 commit