1. 30 Aug, 2013 1 commit
  2. 22 Aug, 2013 3 commits
    • Alex Bligh's avatar
      aio / timers: Switch entire codebase to the new timer API · bc72ad67
      Alex Bligh authored
      This is an autogenerated patch using scripts/switch-timer-api.
      Switch the entire code base to using the new timer API.
      Note this patch may introduce some line length issues.
      Signed-off-by: default avatarAlex Bligh <alex@alex.org.uk>
      Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    • MORITA Kazutaka's avatar
      block: Produce zeros when protocols reading beyond end of file · 893a8f62
      MORITA Kazutaka authored
      While Asias is debugging an issue creating qcow2 images on top of
      non-file protocols.  It boils down to this example using NBD:
      $ qemu-io -c 'open -g nbd+unix:///?socket=/tmp/nbd.sock' -c 'read -v 0 512'
      Notice the open -g option to set bs->growable.  This means you can
      read/write beyond end of file.  Reading beyond end of file is supposed
      to produce zeroes.
      We rely on this behavior in qcow2_create2() during qcow2 image
      creation.  We create a new file and then write the qcow2 header
      structure using bdrv_pwrite().  Since QCowHeader is not a multiple of
      sector size, block.c first uses bdrv_read() on the empty file to fetch
      the first sector (should be all zeroes).
      Here is the output from the qemu-io NBD example above:
      $ qemu-io -c 'open -g nbd+unix:///?socket=/tmp/nbd.sock
      ' -c 'read -v 0 512'
      00000000:  ab ab ab ab ab ab ab ab ab ab ab ab ab ab ab ab  ................
      00000010:  ab ab ab ab ab ab ab ab ab ab ab ab ab ab ab ab  ................
      00000020:  ab ab ab ab ab ab ab ab ab ab ab ab ab ab ab ab  ................
      We are not zeroing the buffer!  As a result qcow2 image creation on top
      of protocols is not guaranteed to work even when file creation is
      supported by the protocol.
      [Adapted this patch to use bs->zero_beyond_eof.
      -- Stefan]
      Signed-off-by: default avatarMORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
      Signed-off-by: default avatarAsias He <asias@redhat.com>
      Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    • Asias He's avatar
      block: Introduce bs->zero_beyond_eof · 0d51b4de
      Asias He authored
      In 4146b46c42e0989cb5842e04d88ab6ccb1713a48 (block: Produce zeros when
      protocols reading beyond end of file), we break qemu-iotests ./check
      -qcow2 022. This happens because qcow2 temporarily sets ->growable = 1
      for vmstate accesses (which are stored beyond the end of regular image
      We introduce the bs->zero_beyond_eof to allow qcow2_load_vmstate() to
      disable ->zero_beyond_eof temporarily in addition to enable ->growable.
      [Since the broken patch "block: Produce zeros when protocols reading
      beyond end of file" has not been merged yet, I have applied this fix
      *first* and will then apply the next patch to keep the tree bisectable.
      -- Stefan]
      Suggested-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
      Signed-off-by: default avatarAsias He <asias@redhat.com>
      Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
  3. 19 Aug, 2013 2 commits
    • Stefan Hajnoczi's avatar
      block: stop relying on io_flush() in bdrv_drain_all() · 88266f5a
      Stefan Hajnoczi authored
      If a block driver has no file descriptors to monitor but there are still
      active requests, it can return 1 from .io_flush().  This is used to spin
      during synchronous I/O.
      Stop relying on .io_flush() and instead check
      QLIST_EMPTY(&bs->tracked_requests) to decide whether there are active
      This is the first step in removing .io_flush() so that event loops no
      longer need to have the concept of synchronous I/O.  Eventually we may
      be able to kill synchronous I/O completely by running everything in a
      coroutine, but that is future work.
      Note this patch moves bs->throttled_reqs initialization to bdrv_new() so
      that bdrv_requests_pending(bs) can safely access it.  In practice bs is
      g_malloc0() so the memory is already zeroed but it's safer to initialize
      the queue properly.
      We also need to fix up block/stream.c:close_unused_images() to prevent
      traversing a dangling pointer while it rearranges the backing file
      chain.  This is necessary since the new bdrv_drain_all() traverses the
      backing file chain.
      Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    • Stefan Hajnoczi's avatar
      block: ensure bdrv_drain_all() works during bdrv_delete() · e1b5c52e
      Stefan Hajnoczi authored
      In bdrv_delete() make sure to call bdrv_make_anon() *after* bdrv_close()
      so that the device is still seen by bdrv_drain_all() when iterating
      Cc: qemu-stable@nongnu.org
      Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
  4. 29 Jul, 2013 1 commit
  5. 26 Jul, 2013 1 commit
  6. 18 Jul, 2013 2 commits
  7. 15 Jul, 2013 2 commits
  8. 05 Jul, 2013 1 commit
  9. 28 Jun, 2013 2 commits
    • Peter Lieven's avatar
      block: change default of .has_zero_init to 0 · 3ac21627
      Peter Lieven authored
      .has_zero_init defaults to 1 for all formats and protocols.
      this is a dangerous default since this means that all
      new added drivers need to manually overwrite it to 0 if
      they do not ensure that a device is zero initialized
      after bdrv_create().
      if a driver needs to explicitly set this value to
      1 its easier to verify the correctness in the review process.
      during review of the existing drivers it turned out
      that ssh and gluster had a wrong default of 1.
      both protocols support host_devices as backend
      which are not by default zero initialized. this
      wrong assumption will lead to possible corruption
      if qemu-img convert is used to write to such a backend.
      vpc and vmdk also defaulted to 1 altough they support
      fixed respectively flat extends. this has to be addresses
      in separate patches. both formats as well as the mentioned
      ssh and gluster are turned to the default of 0 with this
      patch for safety.
      a similar problem with the wrong default existed for
      iscsi most likely because the driver developer did
      oversee the default value of 1.
      Signed-off-by: default avatarPeter Lieven <pl@kamp.de>
      Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    • Stefan Hajnoczi's avatar
      block: add bdrv_add_before_write_notifier() · d616b224
      Stefan Hajnoczi authored
      The bdrv_add_before_write_notifier() function installs a callback that
      is invoked before a write request is processed.  This will be used to
      implement copy-on-write point-in-time snapshots where we need to copy
      out old data before overwriting it.
      Note that BdrvTrackedRequest is moved to block_int.h since it is passed
      to .notify() functions.
      Reviewed-by: default avatarEric Blake <eblake@redhat.com>
      Reviewed-by: default avatarKevin Wolf <kwolf@redhat.com>
      Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
      Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
  10. 24 Jun, 2013 1 commit
    • Kevin Wolf's avatar
      block: Always enable discard on the protocol level · 50b05b6f
      Kevin Wolf authored
      Turning on discard options in qcow2 doesn't help a lot when the discard
      requests that it issues are thrown away by the raw-posix layer. This
      patch always enables discard functionality on the protocol level so that
      it's the image format's responsibility to send (or not) discard
      requests. Requests sent by the guest will be allowed or ignored by the
      top level BlockDriverState, which depends on the discard=... option like
      In particular, this means that even without specifying options, the
      qcow2 default of discarding deleted snapshots actually takes effect now,
      both for qemu and qemu-img.
      Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
      Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
  11. 17 Jun, 2013 1 commit
  12. 06 Jun, 2013 1 commit
  13. 04 Jun, 2013 4 commits
    • Wenchao Xia's avatar
      block: move qmp and info dump related code to block/qapi.c · f364ec65
      Wenchao Xia authored
      This patch is a pure code move patch, except following modification:
      1 get_human_readable_size() is changed to static function.
      2 dump_human_image_info() is renamed to bdrv_image_info_dump().
      3 in qmp_query_block() and qmp_query_blockstats, use bdrv_next(bs)
      instead of direct traverse of global array 'bdrv_states'.
      4 collect_snapshots() and collect_image_info() are renamed, unused parameter
      *fmt in collect_image_info() is removed.
      5 code style fix.
      To avoid conflict and tip better, macro in header file is BLOCK_QAPI_H
      instead of QAPI_H. Now block.h and snapshot.h are at the same level in
      include path, block_int.h and qapi.h will both include them.
      Signed-off-by: default avatarWenchao Xia <xiawenc@linux.vnet.ibm.com>
      Reviewed-by: default avatarEric Blake <eblake@redhat.com>
      Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    • Wenchao Xia's avatar
      block: move snapshot code in block.c to block/snapshot.c · de08c606
      Wenchao Xia authored
      All snapshot related code, except bdrv_snapshot_dump() and
      bdrv_is_snapshot(), is moved to block/snapshot.c. bdrv_snapshot_dump()
      will be moved to another file later. bdrv_is_snapshot() is not related
      with internal snapshot. It also fixes small code style errors reported
      by check script.
      Signed-off-by: default avatarWenchao Xia <xiawenc@linux.vnet.ibm.com>
      Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    • Stefan Hajnoczi's avatar
      block: drop bs_snapshots global variable · 29d78271
      Stefan Hajnoczi authored
      The bs_snapshots global variable points to the BlockDriverState which
      will be used to save vmstate.  This is really a savevm.c concept but was
      moved into block.c:bdrv_snapshots() when it became clear that hotplug
      could result in a dangling pointer.
      While auditing the block layer's global state I came upon bs_snapshots
      and realized that a variable is not necessary here.  Simply find the
      first BlockDriverState capable of internal snapshots each time this is
      The behavior of bdrv_snapshots() is preserved across hotplug because new
      drives are always appended to the bdrv_states list.  This means that
      calling the new find_vmstate_bs() function is idempotent - it returns
      the same BlockDriverState unless it was hot-unplugged.
      Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
      Reviewed-by: default avatarEric Blake <eblake@redhat.com>
      Reviewed-by: default avatarWenchao Xia <xiawenc@linux.vnet.ibm.com>
      Signed-off-by: default avatarWenchao Xia <xiawenc@linux.vnet.ibm.com>
      Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    • Fam Zheng's avatar
      block: add block driver read only whitelist · b64ec4e4
      Fam Zheng authored
      We may want to include a driver in the whitelist for read only tasks
      such as diagnosing or exporting guest data (with libguestfs as a good
      example). This patch introduces a readonly whitelist option, and for
      backward compatibility, the old configure option --block-drv-whitelist
      is now an alias to rw whitelist.
      Drivers in readonly list is only permitted to open file readonly, and
      returns -ENOTSUP for RW opening.
      E.g. To include vmdk readonly, and others read+write:
          ./configure --target-list=x86_64-softmmu \
                      --block-drv-rw-whitelist=qcow2,raw,file,qed \
      Signed-off-by: default avatarFam Zheng <famz@redhat.com>
      Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
  14. 14 May, 2013 1 commit
  15. 22 Apr, 2013 6 commits
  16. 15 Apr, 2013 2 commits
  17. 05 Apr, 2013 4 commits
  18. 28 Mar, 2013 1 commit
  19. 22 Mar, 2013 4 commits