Commit f0f0fdfe authored by Kevin Wolf's avatar Kevin Wolf
Browse files

block: Add return value for bdrv_flush_all()

bdrv_flush() can fail, and bdrv_flush_all() should return an error as
well if this happens for a block device. It returns the first error
return now, but still at least tries to flush the remaining devices even
in error cases.
Signed-off-by: default avatarKevin Wolf <>
Reviewed-by: default avatarStefan Hajnoczi <>
parent 7a370406
......@@ -2910,13 +2910,19 @@ int bdrv_get_flags(BlockDriverState *bs)
return bs->open_flags;
void bdrv_flush_all(void)
int bdrv_flush_all(void)
BlockDriverState *bs;
int result = 0;
QTAILQ_FOREACH(bs, &bdrv_states, list) {
int ret = bdrv_flush(bs);
if (ret < 0 && !result) {
result = ret;
return result;
int bdrv_has_zero_init_1(BlockDriverState *bs)
......@@ -267,7 +267,7 @@ void bdrv_clear_incoming_migration_all(void);
/* Ensure contents are flushed to disk. */
int bdrv_flush(BlockDriverState *bs);
int coroutine_fn bdrv_co_flush(BlockDriverState *bs);
void bdrv_flush_all(void);
int bdrv_flush_all(void);
void bdrv_close_all(void);
void bdrv_drain_all(void);
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment