Commit 4809c612 authored by Johan Bengtsson's avatar Johan Bengtsson Committed by Peter Maydell
Browse files

target-arm: Fix mixup in decoding of saturating add and sub

The thumb2 decoder contained a mixup between the bit controlling
doubling and the bit controlling if the operation was an add or a sub.
Signed-off-by: default avatarJohan Bengtsson <>
Signed-off-by: default avatarPeter Maydell <>
Reviewed-by: default avatarNathan Froyd <>
parent 2af9ab77
......@@ -7713,9 +7713,9 @@ static int disas_thumb2_insn(CPUState *env, DisasContext *s, uint16_t insn_hw1)
/* Saturating add/subtract. */
tmp = load_reg(s, rn);
tmp2 = load_reg(s, rm);
if (op & 2)
gen_helper_double_saturate(tmp, tmp);
if (op & 1)
gen_helper_double_saturate(tmp, tmp);
if (op & 2)
gen_helper_sub_saturate(tmp, tmp2, tmp);
gen_helper_add_saturate(tmp, tmp, tmp2);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment