Commit 08b392e1 authored by Kevin Wolf's avatar Kevin Wolf
Browse files

block: Rename variable to avoid shadowing

bdrv_open() uses two different variables called options. Rename one of
them to avoid confusion and to allow the outer one to be accessed
Signed-off-by: default avatarKevin Wolf <>
Reviewed-by: default avatarEric Blake <>
parent 6963a30d
......@@ -896,7 +896,7 @@ int bdrv_open(BlockDriverState *bs, const char *filename, QDict *options,
BlockDriverState *bs1;
int64_t total_size;
BlockDriver *bdrv_qcow2;
QEMUOptionParameter *options;
QEMUOptionParameter *create_options;
char backing_filename[PATH_MAX];
/* if snapshot, we create a temporary backing file and open it
......@@ -928,17 +928,19 @@ int bdrv_open(BlockDriverState *bs, const char *filename, QDict *options,
bdrv_qcow2 = bdrv_find_format("qcow2");
options = parse_option_parameters("", bdrv_qcow2->create_options, NULL);
create_options = parse_option_parameters("", bdrv_qcow2->create_options,
set_option_parameter_int(options, BLOCK_OPT_SIZE, total_size);
set_option_parameter(options, BLOCK_OPT_BACKING_FILE, backing_filename);
set_option_parameter_int(create_options, BLOCK_OPT_SIZE, total_size);
set_option_parameter(create_options, BLOCK_OPT_BACKING_FILE,
if (drv) {
set_option_parameter(options, BLOCK_OPT_BACKING_FMT,
set_option_parameter(create_options, BLOCK_OPT_BACKING_FMT,
ret = bdrv_create(bdrv_qcow2, tmp_filename, options);
ret = bdrv_create(bdrv_qcow2, tmp_filename, create_options);
if (ret < 0) {
goto fail;
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment