Skip to content
  • Markus Armbruster's avatar
    hw: Clean up bogus default boot order · c1654732
    Markus Armbruster authored
    
    
    We set default boot order "cad" in every single machine definition
    except "pseries" and "moxiesim", even though very few boards actually
    care for boot order, and "cad" makes sense for even fewer.
    
    Machines that care:
    
    * pc and its variants
    
      Accept up to three letters 'a', 'b' (undocumented alias for 'a'),
      'c', 'd' and 'n'.  Reject all others (fatal with -boot).
    
    * nseries (n800, n810)
    
      Check whether order starts with 'n'.  Silently ignored otherwise.
    
    * prep, g3beige, mac99
    
      Extract the first character the machine understands (subset of
      'a'..'f').  Silently ignored otherwise.
    
    * spapr
    
      Accept an arbitrary string (vl.c restricts it to contain only
      'a'..'p', no duplicates).
    
    * sun4[mdc]
    
      Use the first character.  Silently ignored otherwise.
    
    Strip characters these machines ignore from their default boot order.
    
    For all other machines, remove the unused default boot order
    alltogether.
    
    Note that my rename of QEMUMachine member boot_order to
    default_boot_order and QEMUMachineInitArgs member boot_device to
    boot_order has a welcome side effect: it makes every use of boot
    orders visible in this patch, for easy review.
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: default avatarLaszlo Ersek <lersek@redhat.com>
    Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    c1654732