Skip to content
  • Markus Armbruster's avatar
    Mostly revert "qemu-help: Sort devices by logical functionality" · 1fc224b4
    Markus Armbruster authored
    This reverts most of commit 3d1237fb
    
    .
    
    The commit claims to sort the output of "-device help" "by
    functionality rather than alphabetical".  Issues:
    
    * The output was unsorted before, not alphabetically sorted.
      Misleading, but harmless enough.
    
    * The commit doesn't just sort the output of "-device help" as it
      claims, it adds categories to each line of "-device help", and it
      prints devices once per category.  In particular, devices without a
      category aren't shown anymore.  Maybe such devices should not exist,
      but they do.  Regression.
    
    * Categories are also added to the output of "info qdm".  Silent
      change, not nice.  Output remains unsorted, unlike "-device help".
    
    I'm going to reimplement the feature we actually want, without the
    warts.  Reverting the flawed commit first should make it easier to
    review.  However, I can't revert it completely, since DeviceClass
    member categories has been put to use.  So leave that part in.
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: default avatarMarcel Apfelbaum <marcel.a@redhat.com>
    Message-id: 1381410021-1538-2-git-send-email-armbru@redhat.com
    Signed-off-by: default avatarAnthony Liguori <aliguori@amazon.com>
    1fc224b4