• Peter Crosthwaite's avatar
    error: Add error_abort · 5d24ee70
    Peter Crosthwaite authored
    Add a special Error * that can be passed to error handling APIs to
    signal that any errors are fatal and should abort QEMU. There are two
    advantages to this:
    
    - allows for brevity when wishing to assert success of Error **
      accepting APIs. No need for this pattern:
            Error * local_err = NULL;
            api_call(foo, bar, &local_err);
            assert_no_error(local_err);
      This also removes the need for _nofail variants of APIs with
      asserting call sites now reduced to 1LOC.
    - SIGABRT happens from within the offending API. When a fatal error
      occurs in an API call (when the caller is asserting sucess) failure
      often means the API itself is broken. With the abort happening in the
      API call now, the stack frames into the call are available at debug
      time. In the assert_no_error scheme the abort happens after the fact.
    
    The exact semantic is that when an error is raised, if the argument
    Error ** matches &error_abort, then the abort occurs immediately. The
    error messaged is reported.
    
    For error_propagate, if the destination error is &error_abort, then
    the abort happens at propagation time.
    Signed-off-by: default avatarPeter Crosthwaite <peter.crosthwaite@xilinx.com>
    Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Signed-off-by: default avatarLuiz Capitulino <lcapitulino@redhat.com>
    5d24ee70
error.h 2.76 KB