• Andrey Ryabinin's avatar
    android: binder: fix binder mmap failures · f4c72c70
    Andrey Ryabinin authored
    binder_update_page_range() initializes only addr and size
    fields in 'struct vm_struct tmp_area;' and passes it to
    Before 71394fe5 ("mm: vmalloc: add flag preventing guard hole allocation")
    this was because map_vm_area() didn't use any other fields
    in vm_struct except addr and size.
    Now get_vm_area_size() (used in map_vm_area()) reads vm_struct's
    flags to determine whether vm area has guard hole or not.
    binder_update_page_range() don't initialize flags field, so
    this causes following binder mmap failures:
    -----------[ cut here ]------------
    WARNING: CPU: 0 PID: 1971 at mm/vmalloc.c:130
    CPU: 0 PID: 1971 Comm: healthd Not tainted 4.0.0-rc1-00399-g7da3fdc-dirty #157
    Hardware name: ARM-Versatile Express
    [<c001246d>] (unwind_backtrace) from [<c000f7f9>] (show_stack+0x11/0x14)
    [<c000f7f9>] (show_stack) from [<c049a221>] (dump_stack+0x59/0x7c)
    [<c049a221>] (dump_stack) from [<c001cf21>] (warn_slowpath_common+0x55/0x84)
    [<c001cf21>] (warn_slowpath_common) from [<c001cfe3>]
    [<c001cfe3>] (warn_slowpath_null) from [<c00c66c5>]
    [<c00c66c5>] (vmap_page_range_noflush) from [<c00c716b>] (map_vm_area+0x27/0x48)
    [<c00c716b>] (map_vm_area) from [<c038ddaf>]
    [<c038ddaf>] (binder_update_page_range) from [<c038e857>]
    [<c038e857>] (binder_mmap) from [<c00c2dc7>] (mmap_region+0x2eb/0x4d4)
    [<c00c2dc7>] (mmap_region) from [<c00c3197>] (do_mmap_pgoff+0x1e7/0x250)
    [<c00c3197>] (do_mmap_pgoff) from [<c00b35b5>] (vm_mmap_pgoff+0x45/0x60)
    [<c00b35b5>] (vm_mmap_pgoff) from [<c00c1f39>] (SyS_mmap_pgoff+0x5d/0x80)
    [<c00c1f39>] (SyS_mmap_pgoff) from [<c000ce81>] (ret_fast_syscall+0x1/0x5c)
    ---[ end trace 48c2c4b9a1349e54 ]---
    binder: 1982: binder_alloc_buf failed to map page at f0e00000 in kernel
    binder: binder_mmap: 1982 b6bde000-b6cdc000 alloc small buf failed -12
    Use map_kernel_range_noflush() instead of map_vm_area() as this is better
    API for binder's purposes and it allows to get rid of 'vm_struct tmp_area' at all.
    Fixes: 71394fe5 ("mm: vmalloc: add flag preventing guard hole allocation")
    Signed-off-by: default avatarAndrey Ryabinin <a.ryabinin@samsung.com>
    Reported-by: default avatarAmit Pundir <amit.pundir@linaro.org>
    Tested-by: default avatarAmit Pundir <amit.pundir@linaro.org>
    Acked-by: default avatarDavid Rientjes <rientjes@google.com>
    Tested-by: default avatarJohn Stultz <john.stultz@linaro.org>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Last commit
Last update
Kconfig Loading commit data...
Makefile Loading commit data...
binder.c Loading commit data...
binder_trace.h Loading commit data...