1. 26 Jul, 2016 1 commit
  2. 17 Mar, 2016 1 commit
  3. 03 Jan, 2013 1 commit
    • Greg Kroah-Hartman's avatar
      Drivers: ide: remove __dev* attributes. · fe31edc8
      Greg Kroah-Hartman authored
      CONFIG_HOTPLUG is going away as an option.  As a result, the __dev*
      markings need to be removed.
      This change removes the use of __devinit, __devexit_p, __devinitdata,
      __devinitconst, and __devexit from these drivers.
      Based on patches originally written by Bill Pemberton, but redone by me
      in order to handle some of the coding style issues better, by hand.
      Cc: Bill Pemberton <wfp5p@virginia.edu>
      Cc: "David S. Miller" <davem@davemloft.net>
      Signed-off-by: 's avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
  4. 05 Oct, 2012 1 commit
  5. 26 Oct, 2010 2 commits
  6. 18 Oct, 2010 1 commit
  7. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      The script does the followings.
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
      The conversion was done in the following steps.
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
      6. percpu.h was updated not to include slab.h.
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: 's avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: 's avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
  8. 19 Jan, 2010 2 commits
  9. 18 Nov, 2009 1 commit
  10. 29 Oct, 2009 1 commit
  11. 07 Jun, 2009 4 commits
  12. 18 Apr, 2009 2 commits
  13. 31 Mar, 2009 1 commit
  14. 27 Mar, 2009 1 commit
    • Bartlomiej Zolnierkiewicz's avatar
      ide: add ->dma_timer_expiry method and remove ->dma_exec_cmd one (v2) · 22117d6e
      Bartlomiej Zolnierkiewicz authored
      * Rename dma_timer_expiry() to ide_dma_sff_timer_expiry() and export it.
      * Add ->dma_timer_expiry method and use it to set hwif->expiry for
        ATA_PROT_DMA protocol in do_rw_taskfile().
      * Initialize ->dma_timer_expiry to ide_dma_sff_timer_expiry() for SFF hosts.
      * Move setting hwif->expiry from ide_execute_command() to its users and drop
        'expiry' argument.
      * Use ide_execute_command() instead of ->dma_exec_cmd in do_rw_taskfile().
      * Remove ->dma_exec_cmd method and its implementations.
      * Unexport ide_execute_command() and ide_dma_intr().
      * Fix CONFIG_BLK_DEV_IDEDMA=n build (noticed by Randy Dunlap).
      * Fix *dma_expiry naming (suggested by Sergei Shtylyov).
      There should be no functional changes caused by this patch.
      Cc: Randy Dunlap <randy.dunlap@oracle.com>
      Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: 's avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  15. 24 Mar, 2009 1 commit
  16. 06 Jan, 2009 3 commits
  17. 29 Dec, 2008 1 commit
    • Bartlomiej Zolnierkiewicz's avatar
      ide: rework handling of serialized ports (v2) · 702c026b
      Bartlomiej Zolnierkiewicz authored
      * hpt366: set IDE_HFLAG_SERIALIZE in ->host_flags if needed
        in init_hwif_hpt366().  Remove HPT_SERIALIZE_IO while at it.
      * Set IDE_HFLAG_SERIALIZE in ->host_flags if needed in
      * Convert init_irq() to use IDE_HFLAG_SERIALIZE together with
        hwif->host to find out ports which need to be serialized.
      * Remove no longer needed save_match() and ide_hwif_t.serialized.
      * Set host's ->host_flags field instead of port's copy.
      This patch should fix the incorrect grouping of port(s) from
      host(s) that need serialization with port(s) that happen to use
      the same IRQ(s) but are from the host(s) that don't need it.
      Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: 's avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  18. 02 Nov, 2008 1 commit
  19. 21 Oct, 2008 1 commit
  20. 17 Oct, 2008 2 commits
  21. 13 Oct, 2008 3 commits
  22. 10 Oct, 2008 5 commits
    • Bartlomiej Zolnierkiewicz's avatar
      ide: add proper PCI PM support (v2) · feb22b7f
      Bartlomiej Zolnierkiewicz authored
      * Keep pointer to ->init_chipset method also in
        struct ide_host and set it in ide_host_alloc_all().
      * Add ide_pci_suspend() and ide_pci_resume() helpers
        (default ->suspend and ->resume implementations).
      * ->init_chipset can no longer be marked __devinit.
      * Add proper PCI PM support to IDE PCI host drivers
        (rz1000.c and tc86c001.c are skipped for now since
        they need to be converted from using ->init_hwif
        to use ->init_chipset instead).
      * Cleanup CONFIG_PM #ifdef-s per akpm's suggestion.
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
      Signed-off-by: 's avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    • Bartlomiej Zolnierkiewicz's avatar
      hpt366: add hpt3xx_disable_fast_irq() helper · 1785192b
      Bartlomiej Zolnierkiewicz authored
      * Factor out disabling of "fast interrupt" prediction from
        init_hwif_hpt366() to hpt3xx_disable_fast_irq() helper.
      * Use hpt3xx_disable_fast_irq() in ->init_chipset instead of
        ->init_hwif method.
        This is a preparation for adding proper PCI PM support.
      While at it:
      * Cache chip type in chip_type variable in hpt3xx_disable_fast_irq().
      There should be no functional changes caused by this patch.
      Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: 's avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    • Bartlomiej Zolnierkiewicz's avatar
      ide: ide_dev_is_sata() -> ata_id_is_sata() · 367d7e78
      Bartlomiej Zolnierkiewicz authored
      * Use optimized ATA version check from Sergei in ata_id_is_sata().
      * ide_dev_is_sata() -> ata_id_is_sata()
      Cc: Jeff Garzik <jgarzik@pobox.com>
      Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: 's avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    • Bartlomiej Zolnierkiewicz's avatar
      ide: include <linux/hdreg.h> only when needed · 3ceca727
      Bartlomiej Zolnierkiewicz authored
      * Include <linux/ata.h> directly in <linux/ide.h>
        instead of through <linux/hdreg.h>.
      * Include <linux/hdreg.h> only when needed.
      Cc: Christoph Hellwig <hch@infradead.org>
      Signed-off-by: 's avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    • Bartlomiej Zolnierkiewicz's avatar
      ide: make drive->id an union (take 2) · 4dde4492
      Bartlomiej Zolnierkiewicz authored
      Make drive->id an unnamed union so id can be accessed either by using
      'u16 *id' or 'struct hd_driveid *driveid'.  Then convert all existing
      drive->id users accordingly (using 'u16 *id' when possible).
      This is an intermediate step to make ide 'struct hd_driveid'-free.
      While at it:
      - Add missing KERN_CONTs in it821x.c.
      - Use ATA_ID_WORDS and ATA_ID_*_LEN defines.
      - Remove unnecessary checks for drive->id.
      - s/drive_table/table/ in ide_in_drive_list().
      - Cleanup ide_config_drive_speed() a bit.
      - s/drive1/dev1/ & s/drive0/dev0/ in ide_undecoded_slave().
      Fix typo in drivers/ide/ppc/pmac.c. (From Stephen Rothwell)
      There should be no functional changes caused by this patch.
      Signed-off-by: 's avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  23. 10 Sep, 2008 1 commit
    • Masoud Sharbiani's avatar
      ide: Fix pointer arithmetic in hpt3xx driver code (3rd try) · 62ff2ecf
      Masoud Sharbiani authored
      git commit 74811f35 causes crash at
      module load (or boot) time on my machine with a hpt374 controller.
      The reason for this is that for initializing second controller which sets
      (hwif->dev == host->dev[1]) to true (1), adds 1 to a void ptr, which
      advances it by one byte instead of advancing it by sizeof(hpt_info) bytes.
      Because of this, all initialization functions get corrupted data in info
      variable which causes a crash at boot time.
      This patch fixes that and makes my machine boot again.
      The card itself is a HPT374 raid conroller: Here is the lspci -v output:
      03:06.0 RAID bus controller: HighPoint Technologies, Inc. HPT374 (rev
              Subsystem: HighPoint Technologies, Inc. Unknown device 0001
              Flags: bus master, 66MHz, medium devsel, latency 120, IRQ 28
              I/O ports at 8000 [size=8]
              I/O ports at 7800 [size=4]
              I/O ports at 7400 [size=8]
              I/O ports at 7000 [size=4]
              I/O ports at 6800 [size=256]
              Expansion ROM at fe8e0000 [disabled] [size=128K]
              Capabilities: [60] Power Management version 2
      03:06.1 RAID bus controller: HighPoint Technologies, Inc. HPT374 (rev
              Subsystem: HighPoint Technologies, Inc. Unknown device 0001
              Flags: bus master, 66MHz, medium devsel, latency 120, IRQ 28
              I/O ports at 9800 [size=8]
              I/O ports at 9400 [size=4]
              I/O ports at 9000 [size=8]
              I/O ports at 8800 [size=4]
              I/O ports at 8400 [size=256]
              Capabilities: [60] Power Management version 2
      Signed-off-by: 's avatarMasoud Sharbiani <masouds@google.com>
      Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      [bart: use dev_get_drvdata() per Sergei's suggestion]
      Signed-off-by: 's avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  24. 18 Aug, 2008 1 commit
  25. 05 Aug, 2008 1 commit