1. 05 Aug, 2008 2 commits
  2. 24 Jul, 2008 6 commits
  3. 23 Jul, 2008 2 commits
  4. 16 Jul, 2008 1 commit
  5. 15 Jul, 2008 1 commit
  6. 29 Apr, 2008 1 commit
  7. 28 Apr, 2008 5 commits
    • Sergei Shtylyov's avatar
      siimage: coding style cleanup (take 2) · 7b255436
      Sergei Shtylyov authored
      Fix 18 errors and several warnings given by checkpatch.pl:
      
      - use of C99 // comments;
      
      - trailing whitespace;
      
      - 'switch' and 'case' not at the same indentation level;
      
      - no space before the open parenthesis of the 'if' and 'switch' statements;
      
      - space between function name and open parenthesis (though I have introduced
        such warnins in some places since the code looks prettier with the spaces);
      
      - including <asm/io.h> instead of <linux/io.h>;
      
      - line over 80 characters.
      
      In addition to these changes, also do the following:
      
      - make the arrays in sil_set_pio_mode() 'static', and make the arrays in
        sil_set_dma_mode() 'static const';
      
      - change the string of the 'if' statements into the 'switch' statement in
        sil_pata_udma_filter();
      
      - drop the needless '==' operators from the 'if' statements where a condition
        is a mere bit test;
      
      - remove needless initializer for the 'tmp' variable in init_chipset_siimage();
      
      - beautify groups of the variable initializers and assignment operators;
      
      - add new line after variable definitions;
      
      - remove new line between the comment and the statements it refers to;
      
      - remove needless curly braces and parentheses;
      
      - fix typos, capitalize acronyms, etc. in the comments...
      Signed-off-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      7b255436
    • Bartlomiej Zolnierkiewicz's avatar
      siimage: remove proc_reports_siimage() · 24cc434a
      Bartlomiej Zolnierkiewicz authored
      * proc_reports_siimage() is now only called by init_chipset_siimage()
        so inline it there.
      
      * Use array instead of switch statement for reporting clock modes.
      
      There should be no functional changes caused by this patch.
      Acked-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      24cc434a
    • Bartlomiej Zolnierkiewicz's avatar
      siimage: add sil_* I/O ops · 165701d9
      Bartlomiej Zolnierkiewicz authored
      Add sil_iowrite{8,16,32}() and sil_ioread{8,16}() helpers, then use them to
      merge code accessing configuration registers through PCI and MMIO together.
      
      [ because of this SATA initialization bits from setup_mmio_siimage() are
        moved to init_chipset_siimage() ]
      
      This also cuts code size a bit:
      
         text    data     bss     dec     hex filename
         4437     164       0    4601    11f9 drivers/ide/pci/siimage.o.before
         3979     164       0    4143    102f drivers/ide/pci/siimage.o.after
      
      While at it:
      
      * Use I/O ops directly instead of using ->IN{B,W} and ->OUT{B,W}.
      
      * Fixup CodingStyle in setup_mmio_siimage().
      
      * Rename 'tmpbyte' variable to 'tmp' in init_chipset_siimage().
      
      There should be no functional changes caused by this patch.
      Acked-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      165701d9
    • Bartlomiej Zolnierkiewicz's avatar
      siimage: do clocking register posting earlier in setup_mmio_siimage() · 24a96ae0
      Bartlomiej Zolnierkiewicz authored
      Do clocking register posting earlier in setup_mmio_siimage()
      to match code in init_chipset_siimage().
      
      This is a preparation for the next patch which merges PCI and MMIO
      code paths together.
      Acked-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      24a96ae0
    • Bartlomiej Zolnierkiewicz's avatar
      ide: add IDE_HFLAG_MMIO host flag (take 2) · c5dd43ec
      Bartlomiej Zolnierkiewicz authored
      * Add IDE_HFLAG_MMIO host flag and set it for hosts which use
        default_hwif_mmiops().
      
      v2:
      * Fix kernel panic in pmac host driver (',' should be '|').
      
        Thanks to Kamalesh for reporting it + testing the fix
        and to Andrew for hinting me about the source of the issue.
      
      Cc: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Cc: Stephen Rothwell <sfr@canb.auug.org.au>
      Cc: Andy Whitcroft <apw@shadowen.org>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      c5dd43ec
  8. 27 Apr, 2008 1 commit
    • Bartlomiej Zolnierkiewicz's avatar
      ide: add struct ide_io_ports (take 3) · 4c3032d8
      Bartlomiej Zolnierkiewicz authored
      * Add struct ide_io_ports and use it instead of `unsigned long io_ports[]`
        in ide_hwif_t.
      
      * Rename io_ports[] in hw_regs_t to io_ports_array[].
      
      * Use un-named union for 'unsigned long io_ports_array[]' and 'struct
        ide_io_ports io_ports' in hw_regs_t.
      
      * Remove IDE_*_OFFSET defines.
      
      v2:
      * scc_pata.c build fix from Stephen Rothwell.
      
      v3:
      * Fix ctl_adrr typo in Sparc-specific part of ns87415.c.
        (Noticed by Andrew Morton)
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      4c3032d8
  9. 26 Apr, 2008 4 commits
  10. 17 Apr, 2008 1 commit
    • Bartlomiej Zolnierkiewicz's avatar
      ide: remove dead/obsolete ->busproc method · 50672e5d
      Bartlomiej Zolnierkiewicz authored
      ->busproc method is used by HDIO_SET_BUSSTATE ioctl but it has no chance
      of working as intended (in 2.4.x days) because to issue an ioctl there
      is a device node needed and:
      
      - for BUSSTATE_TRISTATE+OFF it is too late (devices are already gone)
      
      - for BUSSTATE_TRISTATE+ON it is too early (devices are not registered yet)
      
      Just remove ->busproc method for now (it was only implemented by hpt366,
      siimage and tc86c001 host drivers).
      
      Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      50672e5d
  11. 07 Apr, 2008 1 commit
    • Sergei Shtylyov's avatar
      siimage: fix kernel oops on PPC 44x · c976816b
      Sergei Shtylyov authored
      Fix kernel oops due to machine check occuring in init_chipset_siimage() on PPC
      44x platforms.  These 32-bit CPUs have 36-bit physical address and PCI I/O and
      memory spaces are mapped beyond 4 GB; arch/ppc/ code has a fixup in ioremap()
      that creates an illusion of the PCI I/O and memory resources being mapped below
      4 GB, while arch/powerpc/ code got rid of this fixup with PPC 44x having instead
      CONFIG_RESOURCES_64BIT=y -- this causes the resources to be truncated to 32-bit
      'unsigned long' type in this driver, and so non-existant memory being ioremap'ed
      and then accessed...
      
      Thanks to Valentine Barshak for providing an initial patch and explanations.
      Signed-off-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      c976816b
  12. 05 Feb, 2008 1 commit
  13. 02 Feb, 2008 3 commits
  14. 01 Feb, 2008 2 commits
  15. 26 Jan, 2008 1 commit
    • Bartlomiej Zolnierkiewicz's avatar
      ide: merge ->fixup and ->quirkproc methods · f01393e4
      Bartlomiej Zolnierkiewicz authored
      * Assign drive->quirk_list in ->quirkproc implementations:
        - hpt366.c::hpt3xx_quirkproc()
        - pdc202xx_new.c::pdcnew_quirkproc()
        - pdc202xx_old.c::pdc202xx_quirkproc()
      
      * Make ->quirkproc void.
      
      * Move calling ->quirkproc from do_identify() to probe_hwif().
      
      * Convert it821x_fixups() to it821x_quirkproc() in it821x.c.
      
      * Convert siimage_fixup() to sil_quirkproc() in siimage.c, also remove
        no longer needed drive->present check from is_dev_seagate_sata().
      
      * Convert ide_undecoded_slave() to accept 'drive' instead of 'hwif'
        as an argument.  Then convert ide_register_hw() to accept 'quirkproc'
        argument instead of 'fixup' one.
      
      * Remove no longer needed ->fixup method.
      Acked-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      f01393e4
  16. 25 Jan, 2008 1 commit
    • Bartlomiej Zolnierkiewicz's avatar
      ide: add IDE_HFLAG_ABUSE_SET_DMA_MODE host flag · 4db90a14
      Bartlomiej Zolnierkiewicz authored
      * Add IDE_HFLAG_ABUSE_SET_DMA_MODE host flag and use it to decide
        what to do with transfer modes < XFER_PIO_0 in ide_set_xfer_rate().
      
      * Set IDE_HFLAG_ABUSE_SET_DMA_MODE in host drivers that need it
        (aec62xx, amd74xx, cs5520, cs5535, hpt34x, hpt366, pdc202xx_old,
        serverworks, tc86c001 and via82cxxx) and cleanup ->set_dma_mode
        methods in host drivers that don't (IDE core code guarantees that
        ->set_dma_mode will be called only for modes which are present
        in SWDMA/MWDMA/UDMA masks).
      
      While at it:
      
      * Add IDE_HFLAGS_HPT34X/HPT3XX/PDC202XX/SVWKS define in
        hpt34x/hpt366/pdc202xx_old/serverworks host driver.
      
      There should be no functionality changes caused by this patch.
      Acked-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      4db90a14
  17. 27 Nov, 2007 1 commit
  18. 19 Oct, 2007 5 commits
  19. 18 Oct, 2007 1 commit
    • Bartlomiej Zolnierkiewicz's avatar
      ide: set drive->autotune in ide_pci_setup_ports() · 85ad93ad
      Bartlomiej Zolnierkiewicz authored
      Majority of host drivers using IDE PCI layer set drive->autotune, the only
      exceptions are:
      
      generic.c
      ns87415.c
      rz1000.c
      trm290.c
      * no ->set_pio_mode method
      
      it821x.c:
      * if memory allocation fails drive->autotune won't be set
        (but there also won't be ->set_pio_mode method in such case)
      
      piix.c:
      * MPIIX controller (no ->init_hwif method so also no ->set_pio_mode method)
      
      However if there is no ->set_pio_mode method there are no changes in behavior
      w.r.t. PIO tuning so always set drive->autotune in ide_pci_setup_ports().
      Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      85ad93ad