1. 10 May, 2011 1 commit
  2. 18 May, 2010 1 commit
  3. 11 May, 2010 1 commit
  4. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  5. 16 Jun, 2009 1 commit
  6. 22 Apr, 2009 1 commit
  7. 07 Apr, 2009 1 commit
    • Anton Vorontsov's avatar
      PCI: Fix oops in pci_vpd_truncate · d407e32e
      Anton Vorontsov authored
      pci_vpd_truncate() should check for dev->vpd->attr, otherwise this might
      happen:
      
        sky2 driver version 1.22
        Unable to handle kernel paging request for data at address 0x0000000c
        Faulting instruction address: 0xc01836fc
        Oops: Kernel access of bad area, sig: 11 [#1]
        [...]
        NIP [c01836fc] pci_vpd_truncate+0x38/0x40
        LR [c029be18] sky2_probe+0x14c/0x518
        Call Trace:
        [ef82bde0] [c029bda4] sky2_probe+0xd8/0x518 (unreliable)
        [ef82be20] [c018a11c] local_pci_probe+0x24/0x34
        [ef82be30] [c018a14c] pci_call_probe+0x20/0x30
        [ef82be50] [c018a330] __pci_device_probe+0x64/0x78
        [ef82be60] [c018a44c] pci_device_probe+0x30/0x58
        [ef82be80] [c01aa270] really_probe+0x78/0x1a0
        [ef82bea0] [c01aa460] __driver_attach+0xa4/0xa8
        [ef82bec0] [c01a96ac] bus_for_each_dev+0x60/0x9c
        [ef82bef0] [c01aa0b4] driver_attach+0x24/0x34
        [ef82bf00] [c01a9e08] bus_add_driver+0x12c/0x1cc
        [ef82bf20] [c01aa87c] driver_register+0x6c/0x110
        [ef82bf30] [c018a770] __pci_register_driver+0x4c/0x9c
        [ef82bf50] [c03782c8] sky2_init_module+0x30/0x40
        [ef82bf60] [c0001dbc] do_one_initcall+0x34/0x1a0
        [ef82bfd0] [c0362240] do_initcalls+0x38/0x58
      
      This happens with CONFIG_SKY2=y, and "ip=on" kernel command line, so
      pci_vpd_truncate() is called before late_initcall(pci_sysfs_init),
      therefore ->attr isn't yet initialized.
      Acked-by: default avatarStephen Hemminger <shemminger@vyatta.com>
      Signed-off-by: default avatarAnton Vorontsov <avorontsov@ru.mvista.com>
      Signed-off-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      d407e32e
  8. 06 Apr, 2009 1 commit
    • Anton Vorontsov's avatar
      PCI: Fix oops in pci_vpd_truncate · d6141668
      Anton Vorontsov authored
      pci_vpd_truncate() should check for dev->vpd->attr, otherwise
      this might happen:
      
      sky2 driver version 1.22
      Unable to handle kernel paging request for data at address 0x0000000c
      Faulting instruction address: 0xc01836fc
      Oops: Kernel access of bad area, sig: 11 [#1]
      [...]
      NIP [c01836fc] pci_vpd_truncate+0x38/0x40
      LR [c029be18] sky2_probe+0x14c/0x518
      Call Trace:
      [ef82bde0] [c029bda4] sky2_probe+0xd8/0x518 (unreliable)
      [ef82be20] [c018a11c] local_pci_probe+0x24/0x34
      [ef82be30] [c018a14c] pci_call_probe+0x20/0x30
      [ef82be50] [c018a330] __pci_device_probe+0x64/0x78
      [ef82be60] [c018a44c] pci_device_probe+0x30/0x58
      [ef82be80] [c01aa270] really_probe+0x78/0x1a0
      [ef82bea0] [c01aa460] __driver_attach+0xa4/0xa8
      [ef82bec0] [c01a96ac] bus_for_each_dev+0x60/0x9c
      [ef82bef0] [c01aa0b4] driver_attach+0x24/0x34
      [ef82bf00] [c01a9e08] bus_add_driver+0x12c/0x1cc
      [ef82bf20] [c01aa87c] driver_register+0x6c/0x110
      [ef82bf30] [c018a770] __pci_register_driver+0x4c/0x9c
      [ef82bf50] [c03782c8] sky2_init_module+0x30/0x40
      [ef82bf60] [c0001dbc] do_one_initcall+0x34/0x1a0
      [ef82bfd0] [c0362240] do_initcalls+0x38/0x58
      
      This happens with CONFIG_SKY2=y, and "ip=on" kernel command line, so
      pci_vpd_truncate() is called before late_initcall(pci_sysfs_init),
      therefore ->attr isn't yet initialized.
      Acked-by: default avatarStephen Hemminger <shemminger@vyatta.com>
      Signed-off-by: default avatarAnton Vorontsov <avorontsov@ru.mvista.com>
      Signed-off-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
      d6141668
  9. 07 Jan, 2009 3 commits
  10. 02 Jul, 2008 1 commit
    • Benjamin Li's avatar
      PCI: Limit VPD read/write lengths for Broadcom 5706, 5708, 5709 rev. · 99cb233d
      Benjamin Li authored
      For Broadcom 5706, 5708, 5709 rev. A nics, any read beyond the
      VPD end tag will hang the device.  This problem was initially
      observed when a vpd entry was created in sysfs
      ('/sys/bus/pci/devices/<id>/vpd').   A read to this sysfs entry
      will dump 32k of data.  Reading a full 32k will cause an access
      beyond the VPD end tag causing the device to hang.  Once the device
      is hung, the bnx2 driver will not be able to reset the device.
      We believe that it is legal to read beyond the end tag and
      therefore the solution is to limit the read/write length.
      
      A majority of this patch is from Matthew Wilcox who gave code for
      reworking the PCI vpd size information.  A PCI quirk added for the
      Broadcom NIC's to limit the read/write's.
      Signed-off-by: default avatarBenjamin Li <benli@broadcom.com>
      Signed-off-by: default avatarMatthew Wilcox <willy@linux.intel.com>
      Signed-off-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
      99cb233d
  11. 20 Apr, 2008 1 commit
    • Ben Hutchings's avatar
      PCI: Expose PCI VPD through sysfs · 94e61088
      Ben Hutchings authored
      Vital Product Data (VPD) may be exposed by PCI devices in several
      ways.  It is generally unsafe to read this information through the
      existing interfaces to user-land because of stateful interfaces.
      
      This adds:
      - abstract operations for VPD access (struct pci_vpd_ops)
      - VPD state information in struct pci_dev (struct pci_vpd)
      - an implementation of the VPD access method specified in PCI 2.2
        (in access.c)
      - a 'vpd' binary file in sysfs directories for PCI devices with VPD
        operations defined
      
      It adds a probe for PCI 2.2 VPD in pci_scan_device() and release of
      VPD state in pci_release_dev().
      Signed-off-by: default avatarBen Hutchings <bhutchings@solarflare.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      94e61088
  12. 04 Dec, 2006 1 commit
  13. 01 Dec, 2006 1 commit
    • Matthew Wilcox's avatar
      PCI: Block on access to temporarily unavailable pci device · 7ea7e98f
      Matthew Wilcox authored
      The existing implementation of pci_block_user_cfg_access() was recently
      criticised for providing out of date information and for returning errors
      on write, which applications won't be expecting.
      
      This reimplementation uses a global wait queue and a bit per device.
      I've open-coded prepare_to_wait() / finish_wait() as I could optimise
      it significantly by knowing that the pci_lock protected us at all points.
      
      It looked a bit funny to be doing a spin_unlock_irqsave(); schedule(),
      so I used spin_lock_irq() for the _user versions of pci_read_config and
      pci_write_config.  Not carrying a flags pointer around made the code
      much less nasty.
      
      Attempts to block an already blocked device hit a BUG() and attempts to
      unblock an already unblocked device hit a WARN().  If we need to block
      access to a device from userspace, it's because it's unsafe for even
      another bit of the kernel to access the device.  An attempt to block
      a device for a second time means we're about to access the device to
      perform some other operation, which could provoke undefined behaviour
      from the device.
      Signed-off-by: default avatarMatthew Wilcox <matthew@wil.cx>
      Acked-by: default avatarAdam Belay <abelay@novell.com>
      Acked-by: default avatarAlan Cox <alan@redhat.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      7ea7e98f
  14. 10 Nov, 2005 1 commit
  15. 28 Oct, 2005 1 commit
    • Brian King's avatar
      [PATCH] PCI: Block config access during BIST · e04b0ea2
      Brian King authored
      Some PCI adapters (eg.  ipr scsi adapters) have an exposure today in that they
      issue BIST to the adapter to reset the card.  If, during the time it takes to
      complete BIST, userspace attempts to access PCI config space, the host bus
      bridge will master abort the access since the ipr adapter does not respond on
      the PCI bus for a brief period of time when running BIST.  On PPC64 hardware,
      this master abort results in the host PCI bridge isolating that PCI device
      from the rest of the system, making the device unusable until Linux is
      rebooted.  This patch is an attempt to close that exposure by introducing some
      blocking code in the PCI code.  When blocked, writes will be humored and reads
      will return the cached value.  Ben Herrenschmidt has also mentioned that he
      plans to use this in PPC power management.
      Signed-off-by: default avatarBrian King <brking@us.ibm.com>
      Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
      Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
      
       drivers/pci/access.c    |   89 ++++++++++++++++++++++++++++++++++++++++++++++++
       drivers/pci/pci-sysfs.c |   20 +++++-----
       drivers/pci/pci.h       |    7 +++
       drivers/pci/proc.c      |   28 +++++++--------
       drivers/pci/syscall.c   |   14 +++----
       include/linux/pci.h     |    7 +++
       6 files changed, 134 insertions(+), 31 deletions(-)
      e04b0ea2
  16. 16 Apr, 2005 1 commit
    • Linus Torvalds's avatar
      Linux-2.6.12-rc2 · 1da177e4
      Linus Torvalds authored
      Initial git repository build. I'm not bothering with the full history,
      even though we have it. We can create a separate "historical" git
      archive of that later if we want to, and in the meantime it's about
      3.2GB when imported into git - space that would just make the early
      git days unnecessarily complicated, when we don't have a lot of good
      infrastructure for it.
      
      Let it rip!
      1da177e4