1. 18 May, 2015 1 commit
    • Bart Van Assche's avatar
      IB/srp: Add 64-bit LUN support · 985aa495
      Bart Van Assche authored
      The SCSI standard defines 64-bit values for LUNs. Large arrays
      employing large or hierarchical LUN numbers become more and more
      common. So update the SRP initiator to use 64-bit LUN numbers.
      See also Hannes Reinecke, commit 9cb78c16 ("scsi: use 64-bit LUNs"),
      June 2014.
      
      The largest LUN number that has been tested is 0xd2003fff00000000.
      
      Checked the following structure sizes with gdb:
      * sizeof(struct srp_cmd) = 48
      * sizeof(struct srp_tsk_mgmt) = 48
      * sizeof(struct srp_aer_req) = 36
      
      The ibmvscsi changes have been compile tested only (on a PPC system).
      Signed-off-by: default avatarBart Van Assche <bart.vanassche@sandisk.com>
      Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
      Reviewed-by: default avatarSagi Grimberg <sagig@mellanox.com>
      Reviewed-by: default avatarYann Droneaud <ydroneaud@opteya.com>
      Cc: Sebastian Parschauer <sebastian.riemer@profitbricks.com>
      Cc: Brian King <brking@linux.vnet.ibm.com>
      Cc: Nathan Fontenot <nfont@linux.vnet.ibm.com>
      Cc: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
      Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
      985aa495
  2. 22 Oct, 2010 1 commit
    • David Dillow's avatar
      IB/srp: Implement SRP_CRED_REQ and SRP_AER_REQ · bb12588a
      David Dillow authored
      This patch adds support for SRP_CRED_REQ to avoid a lockup by targets
      that use that mechanism to return credits to the initiator. This
      prevents a lockup observed in the field where we would never add the
      credits from the SRP_CRED_REQ to our current count, and would therefore
      never send another command to the target.
      
      Minimal support for SRP_AER_REQ is also added, as these messages can
      also be used to convey additional credits to the initiator.
      
      Based upon extensive debugging and code by Bart Van Assche and a bug
      report by Chris Worley.
      Signed-off-by: default avatarDavid Dillow <dillowda@ornl.gov>
      Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
      bb12588a
  3. 17 Jun, 2006 1 commit
  4. 28 Apr, 2006 1 commit
    • Roland Dreier's avatar
      [SCSI] srp.h: avoid padding of structs · ec448a0a
      Roland Dreier authored
      Several structs in <scsi/srp.h> get padded to a multiple of 8 bytes on
      64-bit architectures and end up with a size that does not match the
      definition in the SRP spec:
      
                                           SRP spec     64-bit
          sizeof (struct indirect_buf)        20          24
          sizeof (struct srp_login_rsp)       52          56
          sizeof (struct srp_rsp)             36          40
      
      Fix this by adding __attribute__((packed)) to the offending structs.
      
      Problem pointed out by Arne Redlich <arne.redlich@xiranet.com>.
      Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
      ec448a0a
  5. 02 Nov, 2005 1 commit