1. 30 Apr, 2016 1 commit
  2. 31 May, 2015 1 commit
  3. 24 Nov, 2014 1 commit
  4. 12 Nov, 2014 1 commit
    • Christoph Hellwig's avatar
      scsi: don't set tagging state from scsi_adjust_queue_depth · c8b09f6f
      Christoph Hellwig authored
      Remove the tagged argument from scsi_adjust_queue_depth, and just let it
      handle the queue depth.  For most drivers those two are fairly separate,
      given that most modern drivers don't care about the SCSI "tagged" status
      of a command at all, and many old drivers allow queuing of multiple
      untagged commands in the driver.
      Instead we start out with the ->simple_tags flag set before calling
      ->slave_configure, which is how all drivers actually looking at
      ->simple_tags except for one worke anyway.  The one other case looks
      broken, but I've kept the behavior as-is for now.
      Except for that we only change ->simple_tags from the ->change_queue_type,
      and when rejecting a tag message in a single driver, so keeping this
      churn out of scsi_adjust_queue_depth is a clear win.
      Now that the usage of scsi_adjust_queue_depth is more obvious we can
      also remove all the trivial instances in ->slave_alloc or ->slave_configure
      that just set it to the cmd_per_lun default.
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      Reviewed-by: default avatarMike Christie <michaelc@cs.wisc.edu>
      Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
      Reviewed-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
  5. 27 Feb, 2014 1 commit
  6. 19 Dec, 2013 1 commit
    • Meelis Roos's avatar
      [SCSI] qla1280: Annotate timer on stack so object debug does not complain · 762a86a9
      Meelis Roos authored
      Object Debug option in 3.13-rc1 resultsin  the following warning, cure
      it by annotating the timer to be on stack. The timer is deleted in the
      same function so stack seems OK.
      ODEBUG: object is on stack, but not annotated
      ------------[ cut here ]------------
      WARNING: CPU: 6 PID: 18 at lib/debugobjects.c:300 __debug_object_init+0x184/0x240()
      Modules linked in:
      CPU: 6 PID: 18 Comm: kworker/u4:1 Tainted: G        W    3.13.0-rc1 #16
      Workqueue: events_unbound async_run_entry_fn
      Call Trace:
      [00000000004585cc] warn_slowpath_common+0x4c/0x80
      [0000000000458614] warn_slowpath_null+0x14/0x40
      [000000000063d524] __debug_object_init+0x184/0x240
      [000000000063d5fc] debug_object_init+0x1c/0x40
      [00000000004645ec] init_timer_key+0xc/0x60
      [00000000006cca60] qla1280_mailbox_command+0xc0/0x2a0
      [00000000006ccdd4] qla1280_set_target_parameters+0x194/0x220
      [00000000006cd324] qla1280_slave_configure+0x384/0x3c0
      [00000000006a5d48] scsi_add_lun+0x5c8/0x640
      [00000000006a62b8] scsi_probe_and_add_lun+0x1b8/0x2e0
      [00000000006a6c2c] __scsi_scan_target+0x8c/0x100
      [00000000006a6cf4] scsi_scan_channel+0x54/0xa0
      [00000000006a7008] scsi_scan_host_selected+0xc8/0x120
      [00000000006a70e0] do_scsi_scan_host+0x80/0xa0
      [00000000006a7164] do_scan_async+0x4/0x20
      [00000000004817b8] async_run_entry_fn+0x58/0x120
      ---[ end trace 9a1420108ebfd590 ]---
      Signed-off-by: default avatarMeelis Roos <mroos@linux.ee>
      Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
  7. 03 Jan, 2013 1 commit
    • Greg Kroah-Hartman's avatar
      Drivers: scsi: remove __dev* attributes. · 6f039790
      Greg Kroah-Hartman authored
      CONFIG_HOTPLUG is going away as an option.  As a result, the __dev*
      markings need to be removed.
      This change removes the use of __devinit, __devexit_p, __devinitdata,
      __devinitconst, and __devexit from these drivers.
      Based on patches originally written by Bill Pemberton, but redone by me
      in order to handle some of the coding style issues better, by hand.
      Cc: Bill Pemberton <wfp5p@virginia.edu>
      Cc: Adam Radford <linuxraid@lsi.com>
      Cc: "James E.J. Bottomley" <JBottomley@parallels.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
  8. 30 Apr, 2012 1 commit
  9. 28 Mar, 2012 1 commit
  10. 01 May, 2011 1 commit
  11. 31 Mar, 2011 1 commit
  12. 16 Nov, 2010 1 commit
    • Jeff Garzik's avatar
      SCSI host lock push-down · f281233d
      Jeff Garzik authored
      Move the mid-layer's ->queuecommand() invocation from being locked
      with the host lock to being unlocked to facilitate speeding up the
      critical path for drivers who don't need this lock taken anyway.
      The patch below presents a simple SCSI host lock push-down as an
      equivalent transformation.  No locking or other behavior should change
      with this patch.  All existing bugs and locking orders are preserved.
      Additionally, add one parameter to queuecommand,
      	struct Scsi_Host *
      and remove one parameter from queuecommand,
      	void (*done)(struct scsi_cmnd *)
      Scsi_Host* is a convenient pointer that most host drivers need anyway,
      and 'done' is redundant to struct scsi_cmnd->scsi_done.
      Minimal code disturbance was attempted with this change.  Most drivers
      needed only two one-line modifications for their host lock push-down.
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      Acked-by: default avatarJames Bottomley <James.Bottomley@suse.de>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
  13. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      The script does the followings.
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
      The conversion was done in the following steps.
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
      6. percpu.h was updated not to include slab.h.
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
  14. 27 Mar, 2010 1 commit
  15. 08 Feb, 2010 1 commit
  16. 20 May, 2009 2 commits
  17. 08 Apr, 2009 1 commit
  18. 07 Apr, 2009 2 commits
  19. 03 Apr, 2009 1 commit
  20. 06 Jan, 2009 1 commit
  21. 29 Dec, 2008 1 commit
  22. 09 Oct, 2008 1 commit
  23. 27 Jul, 2008 1 commit
  24. 23 May, 2008 1 commit
    • Harvey Harrison's avatar
      scsi: fix integer as NULL pointer warning · 9bcf0910
      Harvey Harrison authored
      drivers/scsi/aha152x.c:3585:60: warning: Using plain integer as NULL pointer
      drivers/scsi/aha152x.c:3845:56: warning: Using plain integer as NULL pointer
      drivers/scsi/qla1280.c:2814:37: warning: Using plain integer as NULL pointer
      drivers/scsi/atp870u.c:750:47: warning: Using plain integer as NULL pointer
      drivers/scsi/3w-9xxx.c:1281:36: warning: Using plain integer as NULL pointer
      drivers/scsi/3w-9xxx.c:1293:36: warning: Using plain integer as NULL pointer
      drivers/scsi/3w-9xxx.c:1301:35: warning: Using plain integer as NULL pointer
      drivers/scsi/hptiop.c:447:10: warning: Using plain integer as NULL pointer
      drivers/scsi/hptiop.c:457:10: warning: Using plain integer as NULL pointer
      drivers/scsi/hptiop.c:479:24: warning: Using plain integer as NULL pointer
      drivers/scsi/hptiop.c:483:22: warning: Using plain integer as NULL pointer
      drivers/scsi/hptiop.c:1213:23: warning: Using plain integer as NULL pointer
      drivers/scsi/hptiop.c:1214:23: warning: Using plain integer as NULL pointer
      Signed-off-by: default avatarHarvey Harrison <harvey.harrison@gmail.com>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
  25. 13 May, 2008 1 commit
    • Jeremy Higdon's avatar
      [SCSI] qla1280: Fix queue depth problem · af5741c6
      Jeremy Higdon authored
      The qla1280 driver was ANDing the output value of mailbox register
      0 with (1 << target-number) to determine whether to enable queueing
      on the target in question.
      But mailbox register 0 has the status code for the mailbox command
      (in this case, Set Target Parameters).  Potential values are:
       * ISP mailbox command complete status codes
      So clearly that is in error.  I can't think what the author of that
      line was looking for in a mailbox register, so I just eliminated the
      AND.  flag is used later in the function, and I think that the later
      usage was also wrong, though it was used to set values that aren't
      used.  Oh well, an overhaul of this driver is not what I want to do
      now -- just a bugfix.
      After the fix, I found that my disks were getting a queue depth of
      255, which is far too many.  Most SCSI disks are limited to 32 or
      64.  In any case, there's no point, queueing up a bunch of commands
      to the adapter that will just result in queue full or starve other
      targets from being issued commands due to running out of internal
      memory.  So I dropped default queue depth to 32 (from which 1 is
      subtracted elsewhere, giving net of 31).
      I tested with a Seagate ST336753LC, and results look good, so
      I'm satisfied with this patch.
      Signed-off-by: default avatarJeremy Higdon <jeremy@sgi.com>
      Acked-by: default avatarJes Sorensen <jes@sgi.com>
      Cc: Stable Tree <stable@kernel.org>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
  26. 02 May, 2008 1 commit
    • Boaz Harrosh's avatar
      [SCSI] Let scsi_cmnd->cmnd use request->cmd buffer · 64a87b24
      Boaz Harrosh authored
       - struct scsi_cmnd had a 16 bytes command buffer of its own.
         This is an unnecessary duplication and copy of request's
         cmd. It is probably left overs from the time that scsi_cmnd
         could function without a request attached. So clean that up.
       - Once above is done, few places, apart from scsi-ml, needed
         adjustments due to changing the data type of scsi_cmnd->cmnd.
       - Lots of drivers still use MAX_COMMAND_SIZE. So I have left
         that #define but equate it to BLK_MAX_CDB. The way I see it
         and is reflected in the patch below is.
         MAX_COMMAND_SIZE - means: The longest fixed-length (*) SCSI CDB
                            as per the SCSI standard and is not related
                            to the implementation.
         BLK_MAX_CDB.     - The allocated space at the request level
       - I have audit all ISA drivers and made sure none use ->cmnd in a DMA
         Operation. Same audit was done by Andi Kleen.
      (*)fixed-length here means commands that their size can be determined
         by their opcode and the CDB does not carry a length specifier, (unlike
         the VARIABLE_LENGTH_CMD(0x7f) command). This is actually not exactly
         true and the SCSI standard also defines extended commands and
         vendor specific commands that can be bigger than 16 bytes. The kernel
         will support these using the same infrastructure used for VARLEN CDB's.
         So in effect MAX_COMMAND_SIZE means the maximum size command
         scsi-ml supports without specifying a cmd_len by ULD's
      Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
  27. 17 Apr, 2008 1 commit
  28. 30 Jan, 2008 1 commit
    • James Bottomley's avatar
      [SCSI] remove use_sg_chaining · d3f46f39
      James Bottomley authored
      With the sg table code, every SCSI driver is now either chain capable
      or broken (or has sg_tablesize set so chaining is never activated), so
      there's no need to have a check in the host template.
      Also tidy up the code by moving the scatterlist size defines into the
      SCSI includes and permit the last entry of the scatterlist pools not
      to be a power of two.
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
  29. 23 Jan, 2008 1 commit
  30. 09 Jan, 2008 1 commit
    • FUJITA Tomonori's avatar
      [SCSI] qla1280: fix 32 bit segment code · 3a43e69c
      FUJITA Tomonori authored
      There's an error remaining in the 32 bit descriptor code after the
      conversion to dma accessors:  req_cnt is left uninitialised.
      qla1280_32bit_start_scsi gives the following warnings:
      drivers/scsi/qla1280.c: In function 'qla1280_32bit_start_scsi':
      drivers/scsi/qla1280.c:3044: warning: unused variable 'dma_handle'
      drivers/scsi/qla1280.c: In function 'qla1280_queuecommand':
      drivers/scsi/qla1280.c:3060: warning: 'req_cnt' is used uninitialized in this function
      drivers/scsi/qla1280.c:3042: note: 'req_cnt' was declared here
      Signed-off-by: default avatarFUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
      Signed-off-by: default avatarJames Bottomley <James.Bottomley@HansenPartnership.com>
  31. 14 Nov, 2007 1 commit
  32. 21 Oct, 2007 1 commit
  33. 16 Oct, 2007 3 commits
  34. 12 Oct, 2007 1 commit
  35. 06 May, 2007 1 commit
  36. 14 Feb, 2007 1 commit
    • Tim Schmielau's avatar
      [PATCH] remove many unneeded #includes of sched.h · cd354f1a
      Tim Schmielau authored
      After Al Viro (finally) succeeded in removing the sched.h #include in module.h
      recently, it makes sense again to remove other superfluous sched.h includes.
      There are quite a lot of files which include it but don't actually need
      anything defined in there.  Presumably these includes were once needed for
      macros that used to live in sched.h, but moved to other header files in the
      course of cleaning it up.
      To ease the pain, this time I did not fiddle with any header files and only
      removed #includes from .c-files, which tend to cause less trouble.
      Compile tested against 2.6.20-rc2 and 2.6.20-rc2-mm2 (with offsets) on alpha,
      arm, i386, ia64, mips, powerpc, and x86_64 with allnoconfig, defconfig,
      allmodconfig, and allyesconfig as well as a few randconfigs on x86_64 and all
      configs in arch/arm/configs on arm.  I also checked that no new warnings were
      introduced by the patch (actually, some warnings are removed that were emitted
      by unnecessarily included header files).
      Signed-off-by: default avatarTim Schmielau <tim@physik3.uni-rostock.de>
      Acked-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>