Commit cb68429d authored by Alexey Khoroshilov's avatar Alexey Khoroshilov Committed by Takashi Iwai

sound: fix check for error condition of register_chrdev()

init_oss_soundcore() compares returned value of register_chrdev()
with -1, while other error codes can be returned.

Found by Linux Driver Verification project (
Signed-off-by: default avatarAlexey Khoroshilov <>
Signed-off-by: default avatarTakashi Iwai <>
parent 5cf92c8b
......@@ -655,7 +655,7 @@ static void cleanup_oss_soundcore(void)
static int __init init_oss_soundcore(void)
if (preclaim_oss &&
register_chrdev(SOUND_MAJOR, "sound", &soundcore_fops) == -1) {
register_chrdev(SOUND_MAJOR, "sound", &soundcore_fops) < 0) {
printk(KERN_ERR "soundcore: sound device already in use.\n");
return -EBUSY;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment