Commit b39599b7 authored by Suman Anna's avatar Suman Anna Committed by Ohad Ben-Cohen

remoteproc: fix the error check for idr_alloc

The new idr_alloc interface returns the allocated id back
on success, so fix the error path to check for negative
values. This was missed out in the newer idr interface
adoption patch, 15fc6110 "remoteproc: convert to idr_alloc()".
Signed-off-by: default avatarSuman Anna <>
Acked-by: default avatarTejun Heo <>
Signed-off-by: default avatarOhad Ben-Cohen <>
parent f6161aa1
......@@ -217,7 +217,7 @@ int rproc_alloc_vring(struct rproc_vdev *rvdev, int i)
* TODO: support predefined notifyids (via resource table)
ret = idr_alloc(&rproc->notifyids, rvring, 0, 0, GFP_KERNEL);
if (ret) {
if (ret < 0) {
dev_err(dev, "idr_alloc failed: %d\n", ret);
dma_free_coherent(dev->parent, size, va, dma);
return ret;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment