Commit a4be7458 authored by Marcin Wojtas's avatar Marcin Wojtas Committed by Greg Kroah-Hartman

clk: mvebu: dynamically allocate resources in Armada CP110 system controller

commit a0245eb76ad0f652f1eb14f48ca2d3c4391aef66 upstream.

Original commit, which added support for Armada CP110 system controller
used global variables for storing all clock information. It worked
fine for Armada 7k SoC, with single CP110 block. After dual-CP110 Armada 8k
was introduced, the data got overwritten and corrupted.

This patch fixes the issue by allocating resources dynamically in the
driver probe and storing it as platform drvdata.

Fixes: d3da3eae ("clk: mvebu: new driver for Armada CP110 system ...")
Signed-off-by: default avatarMarcin Wojtas <>
Reviewed-by: default avatarThomas Petazzoni <>
Signed-off-by: default avatarStephen Boyd <>
Signed-off-by: default avatarGreg Kroah-Hartman <>
parent a6cf0bc8
......@@ -81,13 +81,6 @@ enum {
#define CP110_GATE_EIP150 25
#define CP110_GATE_EIP197 26
static struct clk *cp110_clks[CP110_CLK_NUM];
static struct clk_onecell_data cp110_clk_data = {
.clks = cp110_clks,
.clk_num = CP110_CLK_NUM,
struct cp110_gate_clk {
struct clk_hw hw;
struct regmap *regmap;
......@@ -196,7 +189,8 @@ static int cp110_syscon_clk_probe(struct platform_device *pdev)
struct regmap *regmap;
struct device_node *np = pdev->dev.of_node;
const char *ppv2_name, *apll_name, *core_name, *eip_name, *nand_name;
struct clk *clk;
struct clk_onecell_data *cp110_clk_data;
struct clk *clk, **cp110_clks;
u32 nand_clk_ctrl;
int i, ret;
......@@ -209,6 +203,20 @@ static int cp110_syscon_clk_probe(struct platform_device *pdev)
if (ret)
return ret;
cp110_clks = devm_kcalloc(&pdev->dev, sizeof(struct clk *),
if (!cp110_clks)
return -ENOMEM;
cp110_clk_data = devm_kzalloc(&pdev->dev,
if (!cp110_clk_data)
return -ENOMEM;
cp110_clk_data->clks = cp110_clks;
cp110_clk_data->clk_num = CP110_CLK_NUM;
/* Register the APLL which is the root of the clk tree */
of_property_read_string_index(np, "core-clock-output-names",
CP110_CORE_APLL, &apll_name);
......@@ -336,10 +344,12 @@ static int cp110_syscon_clk_probe(struct platform_device *pdev)
cp110_clks[CP110_MAX_CORE_CLOCKS + i] = clk;
ret = of_clk_add_provider(np, cp110_of_clk_get, &cp110_clk_data);
ret = of_clk_add_provider(np, cp110_of_clk_get, cp110_clk_data);
if (ret)
goto fail_clk_add;
platform_set_drvdata(pdev, cp110_clks);
return 0;
......@@ -366,6 +376,7 @@ fail0:
static int cp110_syscon_clk_remove(struct platform_device *pdev)
struct clk **cp110_clks = platform_get_drvdata(pdev);
int i;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment