Commit 34c9a0ff authored by Herbert Xu's avatar Herbert Xu Committed by Linus Torvalds

crypto: fix broken crypto_register_instance() module handling

Commit 9c521a20 ("crypto: api - remove instance when test failed")
tried to grab a module reference count before the module was even set.

Worse, it then goes on to free the module reference count after it is
set so you quickly end up with a negative module reference count which
prevents people from using any instances belonging to that module.

This patch moves the module initialisation before the reference
Reported-by: default avatarLinus Torvalds <>
Signed-off-by: default avatarHerbert Xu <>
Signed-off-by: default avatarLinus Torvalds <>
parent eea3a002
......@@ -525,12 +525,12 @@ int crypto_register_instance(struct crypto_template *tmpl,
if (err)
return err;
if (unlikely(!crypto_mod_get(&inst->alg)))
return -EAGAIN;
inst->alg.cra_module = tmpl->module;
inst->alg.cra_flags |= CRYPTO_ALG_INSTANCE;
if (unlikely(!crypto_mod_get(&inst->alg)))
return -EAGAIN;
larval = __crypto_register_alg(&inst->alg);
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment