Commit 0b82ac37 authored by Serge E. Hallyn's avatar Serge E. Hallyn Committed by Linus Torvalds

devices cgroup: allow mkfifo

The devcgroup_inode_permission() hook in the devices whitelist cgroup has
always bypassed access checks on fifos.  But the mknod hook did not.  The
devices whitelist is only about block and char devices, and fifos can't
even be added to the whitelist, so fifos can't be created at all except by
tasks which have 'a' in their whitelist (meaning they have access to all

Fix the behavior by bypassing access checks to mkfifo.
Signed-off-by: default avatarSerge E. Hallyn <>
Cc: Li Zefan <>
Cc: Pavel Emelyanov <>
Cc: Paul Menage <>
Cc: Lai Jiangshan <>
Cc: KOSAKI Motohiro <>
Cc: James Morris <>
Reported-by: default avatarDaniel Lezcano <>
Cc: <>		[2.6.27.x]
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent 116e0575
......@@ -513,6 +513,9 @@ int devcgroup_inode_mknod(int mode, dev_t dev)
struct dev_cgroup *dev_cgroup;
struct dev_whitelist_item *wh;
if (!S_ISBLK(mode) && !S_ISCHR(mode))
return 0;
dev_cgroup = task_devcgroup(current);
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment