• Bhaktipriya Shridhar's avatar
    spi: spi-mpc52xx-psc: Remove deprecated create_singlethread_workqueue · ac96b737
    Bhaktipriya Shridhar authored
    The workqueue "workqueue" has a single work item(&mps->work)
    doesn't require ordering. Also, it is not being used on a memory reclaim
    path. Hence, the singlethreaded workqueue has been replaced with the use
    of system_wq.
    System workqueues have been able to handle high level of concurrency
    for a long time now and hence it's not required to have a singlethreaded
    workqueue just to gain concurrency. Unlike a dedicated per-cpu workqueue
    created with create_singlethread_workqueue(), system_wq allows multiple
    work items to overlap executions even on the same CPU; however, a
    per-cpu workqueue doesn't have any CPU locality or global ordering
    guarantee unless the target CPU is explicitly specified and thus the
    increase of local concurrency shouldn't make any difference.
    Work item has been flushed in mpc52xx_psc_spi_of_remove() to ensure that
    nothing is pending while disconnecting the driver.
    Signed-off-by: default avatarBhaktipriya Shridhar <bhaktipriya96@gmail.com>
    Acked-by: default avatarTejun Heo <tj@kernel.org>
    Signed-off-by: default avatarMark Brown <broonie@kernel.org>