Skip to content
  • Julia Lawall's avatar
    drivers/video/carminefb.c: improve error handling · e045da7d
    Julia Lawall authored
    This code had an error handling goto to the wrong place, a misplaced
    release_mem_region, and a duplicated release_mem_region.
    
    The semantic match that finds the double release_mem_region is as follows:
    (http://coccinelle.lip6.fr/
    
    )
    
    // <smpl>
    @r@
    expression e1,e2,e3;
    position p1,p2,p3;
    @@
    release_mem_region@p1(e1, e2)@p3;
    ... when != request_mem_region(e1,e2,e3)
    release_mem_region(e1, e2)@p2;
    
    @@
    expression e <= r.e1,e3;
    expression r.e1,e2;
    position r.p1,r.p2,r.p3,p!=r.p1;
    @@
    *release_mem_region(e1, e2)@p3;
    ... when != e = e3
    *release_mem_region@p(e1, e2)@p2;// </smpl>
    
    Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
    Signed-off-by: default avatarPaul Mundt <lethal@linux-sh.org>
    e045da7d