Skip to content
  • Frank Sorenson's avatar
    sunrpc: Fix bit count when setting hashtable size to power-of-two · 34ae685c
    Frank Sorenson authored
    
    
    Author: Frank Sorenson <sorenson@redhat.com>
    Date:   2016-06-27 13:55:48 -0500
    
        sunrpc: Fix bit count when setting hashtable size to power-of-two
    
        The hashtable size is incorrectly calculated as the next higher
        power-of-two when being set to a power-of-two.  fls() returns the
        bit number of the most significant set bit, with the least
        significant bit being numbered '1'.  For a power-of-two, fls()
        will return a bit number which is one higher than the number of bits
        required, leading to a hashtable which is twice the requested size.
    
        In addition, the value of (1 << nbits) will always be at least num,
        so the test will never be true.
    
        Fix the hash table size calculation to correctly set hashtable
        size, and eliminate the unnecessary check.
    
    Signed-off-by: default avatarFrank Sorenson <sorenson@redhat.com>
    
    Signed-off-by: default avatarTrond Myklebust <trond.myklebust@primarydata.com>
    34ae685c