Skip to content
  • Vladimir Davydov's avatar
    memcg, slab: clean up memcg cache initialization/destruction · 1aa13254
    Vladimir Davydov authored
    
    
    Currently, we have rather a messy function set relating to per-memcg
    kmem cache initialization/destruction.
    
    Per-memcg caches are created in memcg_create_kmem_cache().  This
    function calls kmem_cache_create_memcg() to allocate and initialize a
    kmem cache and then "registers" the new cache in the
    memcg_params::memcg_caches array of the parent cache.
    
    During its work-flow, kmem_cache_create_memcg() executes the following
    memcg-related functions:
    
     - memcg_alloc_cache_params(), to initialize memcg_params of the newly
       created cache;
     - memcg_cache_list_add(), to add the new cache to the memcg_slab_caches
       list.
    
    On the other hand, kmem_cache_destroy() called on a cache destruction
    only calls memcg_release_cache(), which does all the work: it cleans the
    reference to the cache in its parent's memcg_params::memcg_caches,
    removes the cache from the memcg_slab_caches list, and frees
    memcg_params.
    
    Such an inconsistency between destruction and initialization paths make
    the code difficult to read, so let's clean this up a bit.
    
    This patch moves all the code relating to registration of per-memcg
    caches (adding to memcg list, setting the pointer to a cache from its
    parent) to the newly created memcg_register_cache() and
    memcg_unregister_cache() functions making the initialization and
    destruction paths look symmetrical.
    
    Signed-off-by: default avatarVladimir Davydov <vdavydov@parallels.com>
    Cc: Michal Hocko <mhocko@suse.cz>
    Cc: Glauber Costa <glommer@gmail.com>
    Cc: Johannes Weiner <hannes@cmpxchg.org>
    Cc: Balbir Singh <bsingharora@gmail.com>
    Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    Cc: Pekka Enberg <penberg@kernel.org>
    Cc: Christoph Lameter <cl@linux.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    1aa13254