Skip to content
  • Rasmus Villemoes's avatar
    compiler.h: add support for malloc attribute · d64e85d3
    Rasmus Villemoes authored
    gcc as far back as at least 3.04 documents the function attribute
    __malloc__.  Add a shorthand for attaching that to a function
    declaration.  This was also suggested by Andi Kleen way back in 2002
    [1], but didn't get applied, perhaps because gcc at that time generated
    the exact same code with and without this attribute.
    
    This attribute tells the compiler that the return value (if non-NULL)
    can be assumed not to alias any other valid pointers at the time of the
    call.
    
    Please note that the documentation for a range of gcc versions (starting
    from around 4.7) contained a somewhat confusing and self-contradicting
    text:
    
      The malloc attribute is used to tell the compiler that a function may
      be treated as if any non-NULL pointer it returns cannot alias any other
      pointer valid when the function returns and *that the memory has
      undefined content*.  [...] Standard functions with this property include
      malloc and *calloc*.
    
    (emphasis mine). The intended meaning has later been clarified [2]:
    
      This tells the compiler that a function is malloc-like, i.e., that the
      pointer P returned by the function cannot alias any other pointer valid
      when the function returns, and moreover no pointers to valid objects
      occur in any storage addressed by P.
    
    What this means is that we can apply the attribute to kmalloc and
    friends, and it is ok for the returned memory to have well-defined
    contents (__GFP_ZERO).  But it is not ok to apply it to kmemdup(), nor
    to other functions which both allocate and possibly initialize the
    memory with existing pointers.  So unless someone is doing something
    pretty perverted kstrdup() should also be a fine candidate.
    
    [1] http://thread.gmane.org/gmane.linux.kernel/57172
    [2] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56955
    
    
    
    Signed-off-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
    Cc: Christoph Lameter <cl@linux.com>
    Cc: Pekka Enberg <penberg@kernel.org>
    Cc: David Rientjes <rientjes@google.com>
    Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    d64e85d3