Skip to content
  • Paul Gortmaker's avatar
    drivers/leds: don't use module_init in non-modular leds-cobalt-raq.c · b83fae0c
    Paul Gortmaker authored
    
    
    This file is built for a bool Kconfig variable, and hence this
    code is either present or absent.  It currently can never be
    modular, so using module_init as an alias for __initcall can be
    somewhat misleading.
    
    Fix this up now, so that we can relocate module_init from
    init.h into module.h in the future.  If we don't do this, we'd
    have to add module.h to obviously non-modular code, and that
    would be a worse thing.
    
    Note that direct use of __initcall is discouraged, vs. one
    of the priority categorized subgroups.  As __initcall gets
    mapped onto device_initcall, our use of device_initcall
    directly in this change means that the runtime impact is
    zero -- it will remain at level 6 in initcall ordering.
    
    And since it can't be modular, we remove all the __exitcall
    stuff related to module_exit() -- it is dead code that won't
    ever be executed.
    
    Cc: Richard Purdie <rpurdie@rpsys.net>
    Cc: linux-leds@vger.kernel.org
    Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
    Acked-by: default avatarJacek Anaszewski <j.anaszewski@samsung.com>
    Signed-off-by: default avatarBryan Wu <cooloney@gmail.com>
    b83fae0c