Skip to content
  • Nick Piggin's avatar
    fs: hlist UP debug fixup · 2c675598
    Nick Piggin authored
    
    
    Po-Yu Chuang <ratbert.chuang@gmail.com> noticed that hlist_bl_set_first could
    crash on a UP system when LIST_BL_LOCKMASK is 0, because
    
    	LIST_BL_BUG_ON(!((unsigned long)h->first & LIST_BL_LOCKMASK));
    
    always evaulates to true.
    
    Fix the expression, and also avoid a dependency between bit spinlock
    implementation and list bl code (list code shouldn't know anything
    except that bit 0 is set when adding and removing elements). Eventually
    if a good use case comes up, we might use this list to store 1 or more
    arbitrary bits of data, so it really shouldn't be tied to locking either,
    but for now they are helpful for debugging.
    
    Signed-off-by: default avatarNick Piggin <npiggin@kernel.dk>
    2c675598