Skip to content
  • Jeff Mahoney's avatar
    kmalloc: return NULL instead of link failure · 1cf3eb2f
    Jeff Mahoney authored
    
    
    The SLAB kmalloc with a constant value isn't consistent with the other
    implementations because it bails out with __you_cannot_kmalloc_that_much
    rather than returning NULL and properly allowing the caller to fall back
    to vmalloc or take other action.  This doesn't happen with a non-constant
    value or with SLOB or SLUB.
    
    Starting with 2.6.28, I've been seeing build failures on s390x.  This is
    due to init_section_page_cgroup trying to allocate 2.5MB when the max size
    for a kmalloc on s390x is 2MB.
    
    It's failing because the value is constant.  The workarounds at the call
    size are ugly and the caller shouldn't have to change behavior depending
    on what the backend of the API is.
    
    So, this patch eliminates the link failure and returns NULL like the other
    implementations.
    
    Signed-off-by: default avatarJeff Mahoney <jeffm@suse.com>
    Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
    Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
    Cc: Christoph Lameter <cl@linux-foundation.org>
    Cc: Pekka Enberg <penberg@cs.helsinki.fi>
    Cc: Matt Mackall <mpm@selenic.com>
    Cc: Nick Piggin <nickpiggin@yahoo.com.au>
    Cc: <stable@kernel.org>		[2.6.28.x]
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarPekka Enberg <penberg@cs.helsinki.fi>
    1cf3eb2f