Skip to content
  • Rusty Russell's avatar
    modules: Fix build error in moduleloader.h · 3a611c3c
    Rusty Russell authored
    
    
    Fengguang Wu's build bot detected that if moduleloader.h is included in
    a C file (used by ftrace and kprobes to access module_alloc() when
    available), that it can fail to build if CONFIG_MODULES and
    CONFIG_MODULES_USE_ELF_REL is not defined.
    
    This is because there's a printk() that dereferences struct module to
    print the name of the module. But as struct module does not exist when
    CONFIG_MODULES is not defined we get this error:
    
       include/linux/moduleloader.h: In function 'apply_relocate':
    >> include/linux/moduleloader.h:48:63: error: dereferencing pointer to
    >> incomplete type
         printk(KERN_ERR "module %s: REL relocation unsupported\n", me->name);
    								  ^
    Reported-by: default avatarkbuild test robot <fengguang.wu@intel.com>
    Based-on-the-true-story-by: default avatarSteven Rostedt <rostedt@goodmis.org>
    Confirms-rustys-story-ends-the-same-by: default avatarSteven Rostedt <rostedt@goodmis.org>
    Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
    3a611c3c