Skip to content
  • Joe Perches's avatar
    checkpatch: add constant comparison on left side test · c5595fa2
    Joe Perches authored
    
    
    "CONST <comparison> variable" checks like:
    
            if (NULL != foo)
    and
            while (0 < bar(...))
    
    where a constant (or what appears to be a constant like an upper case
    identifier) is on the left of a comparison are generally preferred to be
    written using the constant on the right side like:
    
            if (foo != NULL)
    and
            while (bar(...) > 0)
    
    Add a test for this.
    
    Add a --fix option too, but only do it when the code is immediately
    surrounded by parentheses to avoid misfixing things like "(0 < bar() +
    constant)"
    
    Signed-off-by: default avatarJoe Perches <joe@perches.com>
    Cc: Nicolas Morey Chaisemartin <nmorey@kalray.eu>
    Cc: Viresh Kumar <viresh.kumar@linaro.org>
    Cc: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    c5595fa2