Skip to content
  • Arnd Bergmann's avatar
    NCR53c406a: don't call free_dma() by default · 6919a366
    Arnd Bergmann authored
    
    
    The NCR53c406a scsi driver normally does not use DMA, unless
    the USE_PIO macro is disabled by modifying the source code.
    
    The call to free_dma() for some reason uses #ifdef USE_DMA,
    which does not do the right thing, since USE_DMA is defined
    as a boolean that is either 0 or 1, but always present.
    
    One case where it gets in the way is randconfig builds on ARM,
    which depending on the configuration does not provide a free_dma()
    function, causing this build error:
    
    drivers/scsi/NCR53c406a.c: In function 'NCR53c406a_release':
    drivers/scsi/NCR53c406a.c:600:3: error: implicit declaration of function 'free_dma' [-Werror=implicit-function-declaration]
       free_dma(shost->dma_channel);
       ^
    
    This changes the code to use #if USE_DMA, to match the
    rest of the file, which seems to be what the author intended.
    
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Reviewed-by: default avatarFinn Thain <fthain@telegraphics.com.au>
    Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
    6919a366