Skip to content
  • Paul E. McKenney's avatar
    rcu: Clean up code based on review feedback from Josh Triplett, part 2 · 1eba8f84
    Paul E. McKenney authored
    
    
    These issues identified during an old-fashioned face-to-face code
    review extending over many hours.
    
    o	Add comments for tricky parts of code, and correct comments
    	that have passed their sell-by date.
    
    o	Get rid of the vestiges of rcu_init_sched(), which is no
    	longer needed now that PREEMPT_RCU is gone.
    
    o	Move the #include of rcutree_plugin.h to the end of
    	rcutree.c, which means that, rather than having a random
    	collection of forward declarations, the new set of forward
    	declarations document the set of plugins.  The new home for
    	this #include also allows __rcu_init_preempt() to move into
    	rcutree_plugin.h.
    
    o	Fix rcu_preempt_check_callbacks() to be static.
    
    Suggested-by: default avatarJosh Triplett <josh@joshtriplett.org>
    Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
    Cc: laijs@cn.fujitsu.com
    Cc: dipankar@in.ibm.com
    Cc: akpm@linux-foundation.org
    Cc: mathieu.desnoyers@polymtl.ca
    Cc: josh@joshtriplett.org
    Cc: dvhltc@us.ibm.com
    Cc: niv@us.ibm.com
    Cc: peterz@infradead.org
    Cc: rostedt@goodmis.org
    Cc: Valdis.Kletnieks@vt.edu
    Cc: dhowells@redhat.com
    LKML-Reference: <12537246443924-git-send-email->
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    Peter Zijlstra <peterz@infradead.org>
    1eba8f84