• Martin K. Petersen's avatar
    block: Inline blk_integrity in struct gendisk · 25520d55
    Martin K. Petersen authored
    Up until now the_integrity profile has been dynamically allocated and
    attached to struct gendisk after the disk has been made active.
    This causes problems because NVMe devices need to register the profile
    prior to the partition table being read due to a mandatory metadata
    buffer requirement. In addition, DM goes through hoops to deal with
    preallocating, but not initializing integrity profiles.
    Since the integrity profile is small (4 bytes + a pointer), Christoph
    suggested moving it to struct gendisk proper. This requires several
     - Moving the blk_integrity definition to genhd.h.
     - Inlining blk_integrity in struct gendisk.
     - Removing the dynamic allocation code.
     - Adding helper functions which allow gendisk to set up and tear down
       the integrity sysfs dir when a disk is added/deleted.
     - Adding a blk_integrity_revalidate() callback for updating the stable
       pages bdi setting.
     - The calls that depend on whether a device has an integrity profile or
       not now key off of the bi->profile pointer.
     - Simplifying the integrity support routines in DM (Mike Snitzer).
    Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
    Reported-by: default avatarChristoph Hellwig <hch@lst.de>
    Reviewed-by: default avatarSagi Grimberg <sagig@mellanox.com>
    Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
    Cc: Dan Williams <dan.j.williams@intel.com>
    Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
    Signed-off-by: default avatarJens Axboe <axboe@fb.com>
partition-generic.c 14.1 KB